Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tier4_control_launch, crosswalk_traffic_light_estimator): fix a mistake when adding prefixes #7423

Conversation

SakodaShintaro
Copy link
Contributor

@SakodaShintaro SakodaShintaro commented Jun 10, 2024

Description

I encountered the following error:

/home/shintarosakoda/autoware/src/universe/autoware.universe/perception/autoware_crosswalk_traffic_light_estimator/src/node.cpp:14:10: fatal error: crosswalk_traffic_light_estimator/node.hpp: そのようなファイルやディレクトリはありません
   14 | #include "crosswalk_traffic_light_estimator/node.hpp"
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

and

+ rosdep install -y --from-paths src --ignore-src --rosdistro humble
ERROR: the following packages/stacks could not have their rosdep keys resolved
to system dependencies:
tier4_control_launch: Cannot locate rosdep definition for [external_cmd_selector]

Related PR

Tests performed

I have confirmed that the build is successful on the local machine and that logging_simulator works properly.

Effects on system behavior

There are no effects on system behavior.

Interface changes

There are no interface changes.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@SakodaShintaro SakodaShintaro added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jun 10, 2024
@github-actions github-actions bot added component:perception Advanced sensor data processing and environment understanding. (auto-assigned) component:launch Launch files, scripts and initialization tools. (auto-assigned) labels Jun 10, 2024
@SakodaShintaro SakodaShintaro marked this pull request as ready for review June 10, 2024 23:55
@takayuki5168 takayuki5168 merged commit aabff3b into autowarefoundation:main Jun 11, 2024
39 checks passed
@takayuki5168
Copy link
Contributor

Thank you!

@SakodaShintaro SakodaShintaro deleted the fix/fix_mistake_when_adding_prefix branch June 18, 2024 08:52
KhalilSelyan pushed a commit that referenced this pull request Jul 22, 2024
…istake when adding prefixes (#7423)

Fixed a mistake when adding prefixes

Signed-off-by: Shintaro Sakoda <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:launch Launch files, scripts and initialization tools. (auto-assigned) component:perception Advanced sensor data processing and environment understanding. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants