Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(crosswalk): change the TTC formula #6033

Merged

Conversation

yuki-takagi-66
Copy link
Contributor

@yuki-takagi-66 yuki-takagi-66 commented Jan 9, 2024

Description

This PR change the TTC formula that would be appropriate for the ego_pass_first judge.

launch: autowarefoundation/autoware_launch#780

Tests performed

psim test and the tier4 internal tests were performed.
https://evaluation.tier4.jp/evaluation/reports/a2e1eedd-1fc7-5667-be85-e912fbca2e44?project_id=prd_jt

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Yuki Takagi <[email protected]>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Jan 9, 2024
@yuki-takagi-66 yuki-takagi-66 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jan 9, 2024
Copy link

codecov bot commented Jan 9, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (599aea0) 15.26% compared to head (2e67a11) 15.26%.
Report is 8 commits behind head on main.

Files Patch % Lines
..._velocity_crosswalk_module/src/scene_crosswalk.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6033   +/-   ##
=======================================
  Coverage   15.26%   15.26%           
=======================================
  Files        1757     1757           
  Lines      121387   121339   -48     
  Branches    37024    37025    +1     
=======================================
- Hits        18529    18528    -1     
+ Misses      82043    81995   -48     
- Partials    20815    20816    +1     
Flag Coverage Δ *Carryforward flag
differential 12.11% <0.00%> (?)
total 15.26% <ø> (+<0.01%) ⬆️ Carriedforward from 776063f

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Yuki Takagi <[email protected]>
Signed-off-by: Yuki Takagi <[email protected]>
Signed-off-by: Yuki Takagi <[email protected]>
Signed-off-by: Yuki Takagi <[email protected]>
@yuki-takagi-66 yuki-takagi-66 changed the title chore(crosswalk): change params feat(crosswalk): change the TTC formula Jan 10, 2024
@yuki-takagi-66 yuki-takagi-66 marked this pull request as ready for review January 10, 2024 04:59
@yuki-takagi-66 yuki-takagi-66 merged commit b51759f into autowarefoundation:main Jan 12, 2024
30 of 33 checks passed
@yuki-takagi-66 yuki-takagi-66 deleted the chore/crosswalk/change-params branch January 12, 2024 04:33
yuki-takagi-66 added a commit to tier4/autoware.universe that referenced this pull request Jan 16, 2024
* change params
* change the TTC formula

Signed-off-by: Yuki Takagi <[email protected]>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 26, 2024
* change params
* change the TTC formula

Signed-off-by: Yuki Takagi <[email protected]>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 28, 2024
* change params
* change the TTC formula

Signed-off-by: Yuki Takagi <[email protected]>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 28, 2024
* change params
* change the TTC formula

Signed-off-by: Yuki Takagi <[email protected]>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
* change params
* change the TTC formula

Signed-off-by: Yuki Takagi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants