-
Notifications
You must be signed in to change notification settings - Fork 665
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(crosswalk): change the TTC formula #6033
Merged
yuki-takagi-66
merged 5 commits into
autowarefoundation:main
from
tier4:chore/crosswalk/change-params
Jan 12, 2024
Merged
feat(crosswalk): change the TTC formula #6033
yuki-takagi-66
merged 5 commits into
autowarefoundation:main
from
tier4:chore/crosswalk/change-params
Jan 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yuki Takagi <[email protected]>
github-actions
bot
added
the
component:planning
Route planning, decision-making, and navigation. (auto-assigned)
label
Jan 9, 2024
yuki-takagi-66
added
the
run:build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
label
Jan 9, 2024
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #6033 +/- ##
=======================================
Coverage 15.26% 15.26%
=======================================
Files 1757 1757
Lines 121387 121339 -48
Branches 37024 37025 +1
=======================================
- Hits 18529 18528 -1
+ Misses 82043 81995 -48
- Partials 20815 20816 +1
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Yuki Takagi <[email protected]>
Signed-off-by: Yuki Takagi <[email protected]>
Signed-off-by: Yuki Takagi <[email protected]>
Signed-off-by: Yuki Takagi <[email protected]>
yuki-takagi-66
changed the title
chore(crosswalk): change params
feat(crosswalk): change the TTC formula
Jan 10, 2024
4 tasks
yuki-takagi-66
requested review from
kyoichi-sugahara,
soblin,
satoshi-ota,
shmpwk,
takayuki5168 and
tkimura4
as code owners
January 10, 2024 04:59
takayuki5168
approved these changes
Jan 12, 2024
yuki-takagi-66
merged commit Jan 12, 2024
b51759f
into
autowarefoundation:main
30 of 33 checks passed
yuki-takagi-66
added a commit
to tier4/autoware.universe
that referenced
this pull request
Jan 16, 2024
* change params * change the TTC formula Signed-off-by: Yuki Takagi <[email protected]>
4 tasks
This was referenced Feb 9, 2024
This was referenced Apr 30, 2024
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
May 26, 2024
* change params * change the TTC formula Signed-off-by: Yuki Takagi <[email protected]>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
May 28, 2024
* change params * change the TTC formula Signed-off-by: Yuki Takagi <[email protected]>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
May 28, 2024
* change params * change the TTC formula Signed-off-by: Yuki Takagi <[email protected]>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
Jun 3, 2024
* change params * change the TTC formula Signed-off-by: Yuki Takagi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component:planning
Route planning, decision-making, and navigation. (auto-assigned)
run:build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR change the TTC formula that would be appropriate for the ego_pass_first judge.
launch: autowarefoundation/autoware_launch#780
Tests performed
psim test and the tier4 internal tests were performed.
https://evaluation.tier4.jp/evaluation/reports/a2e1eedd-1fc7-5667-be85-e912fbca2e44?project_id=prd_jt
Not applicable.
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.