Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(crosswalk)!: change ego min assumed speed #6904

Conversation

yuki-takagi-66
Copy link
Contributor

@yuki-takagi-66 yuki-takagi-66 commented Apr 30, 2024

Description

Parameter update to follow the change of significance by #6033
Screencast from 04-30-2024 09:16:56 AM.webm

launch PR: autowarefoundation/autoware_launch#977

Tests performed

psim and tier4 internal tests

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Yuki Takagi <[email protected]>
Signed-off-by: Yuki Takagi <[email protected]>
Copy link
Contributor

@shmpwk shmpwk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shmpwk shmpwk added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Apr 30, 2024
@yuki-takagi-66 yuki-takagi-66 merged commit dc62238 into autowarefoundation:main May 7, 2024
33 of 35 checks passed
@yuki-takagi-66 yuki-takagi-66 deleted the feat/crosswalk/change-ego-min-speed branch May 7, 2024 03:33
yuki-takagi-66 added a commit to tier4/autoware.universe that referenced this pull request May 7, 2024
shmpwk pushed a commit to tier4/autoware.universe that referenced this pull request May 7, 2024
shmpwk pushed a commit to tier4/autoware.universe that referenced this pull request May 7, 2024
vividf pushed a commit to vividf/autoware.universe that referenced this pull request May 16, 2024
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants