Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(crosswalk): change LATER param #6371

Merged

Conversation

yuki-takagi-66
Copy link
Contributor

Description

change ego pass later param related to
#6033
autowarefoundation/autoware_launch#780

Tests performed

psim and tier4 internal test

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Yuki Takagi <[email protected]>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Feb 9, 2024
@yuki-takagi-66 yuki-takagi-66 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Feb 9, 2024
Copy link

codecov bot commented Feb 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4409d20) 14.87% compared to head (8c9d3fa) 14.87%.
Report is 19 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6371      +/-   ##
==========================================
- Coverage   14.87%   14.87%   -0.01%     
==========================================
  Files        1841     1841              
  Lines      126588   126644      +56     
  Branches    37962    37996      +34     
==========================================
+ Hits        18828    18836       +8     
- Misses      86539    86581      +42     
- Partials    21221    21227       +6     
Flag Coverage Δ *Carryforward flag
differential 11.68% <ø> (?)
total 14.87% <ø> (ø) Carriedforward from 4409d20

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@kyoichi-sugahara kyoichi-sugahara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yuki-takagi-66 yuki-takagi-66 merged commit c8790ab into autowarefoundation:main Feb 13, 2024
30 of 33 checks passed
@yuki-takagi-66 yuki-takagi-66 deleted the crosswalk/change-LATER-param branch February 13, 2024 05:29
yuki-takagi-66 added a commit to tier4/autoware.universe that referenced this pull request Feb 19, 2024
StepTurtle pushed a commit to StepTurtle/autoware.universe that referenced this pull request Feb 28, 2024
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants