feat(crosswalk)!: change a hard coding number and set as param #977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yuki Takagi <[email protected]>
Signed-off-by: Yuki Takagi <[email protected]>
yuki-takagi-66
requested review from
takayuki5168,
rej55,
satoshi-ota and
shmpwk
as code owners
4 tasks
shmpwk
approved these changes
Apr 30, 2024
takayuki5168
approved these changes
May 7, 2024
maxime-clem
pushed a commit
to maxime-clem/autoware_launch
that referenced
this pull request
May 13, 2024
…arefoundation#977) (autowarefoundation#849) * change param Signed-off-by: Yuki Takagi <[email protected]>
Ericpotato
added a commit
to tier4/autoware_launch
that referenced
this pull request
Nov 6, 2024
…ation#977) (autowarefoundation#998) * add logging_ecu monitoring settings * style(pre-commit): autofix * remove unnecessary parameters and refe paths for launching system_monitor * style(pre-commit): autofix * Update autoware_launch/launch/components/ecu_monitoring.logging.py * remove unused python packages --------- Signed-off-by: Ericpotato <[email protected]> Co-authored-by: Ericpotato <[email protected]> Co-authored-by: Shumpei Wakabayashi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Parameter update to follow the change of significance by autowarefoundation/autoware.universe#6033
Screencast from 04-30-2024 09:16:56 AM.webm
PR in universe autowarefoundation/autoware.universe#6904
Tests performed
psim and tier4 internal test
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.