feat: add common interface tools test #5815
Open
+82
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shulanbushangshu
requested review from
isamu-takagi,
tkhmy and
yabuta
as code owners
github-actions
bot
added
the
component:common
shulanbushangshu
added
the
tag:run-build-and-test-differential
| @@ -15,9 +15,11 @@ | |||
| <depend>diagnostic_updater</depend> | |||
| <depend>fmt</depend> | |||
| <depend>rclcpp</depend> | |||
| <depend>service_log_checker</depend> | |||
There was a problem hiding this comment.
The service_log_checker is not a package. This causes CI to fail.
| <depend>tier4_system_msgs</depend> | ||
| <depend>yaml_cpp_vendor</depend> | ||
|
|
||
| <test_depend>ament_cmake_ros</test_depend> |
There was a problem hiding this comment.
This package uses ament_cmake_auto, so ament_cmake_ros is not needed if you use ament_auto_add_gtest. instead of ament_add_ros_isolated_gtest.
| @@ -0,0 +1,63 @@ | |||
| // Copyright 2023 TIER IV, Inc. | |||
There was a problem hiding this comment.
Suggested change
| // Copyright 2023 TIER IV, Inc. | |
| // Copyright 2023 The Autoware Contributors |
|
|
||
| TEST(service, checker) | ||
| { | ||
| { |
There was a problem hiding this comment.
unused block namespace
shulanbushangshu
force-pushed
the
comm_tools
branch
from
cefdb57 to
0f69c40
Compare
|
This pull request has been automatically marked as stale because it has not had recent activity. |
|
@shulanbushangshu could you rebase this to the latest main? |
shulanbushangshu
force-pushed
the
comm_tools
branch
from
d6fbd39 to
01944ef
Compare
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
Signed-off-by: jack.song <[email protected]>
shulanbushangshu
force-pushed
the
comm_tools
branch
from
da30bee to
cb204b6
Compare
Signed-off-by: jack.song <[email protected]>
shulanbushangshu
force-pushed
the
comm_tools
branch
from
fb8816f to
667ded2
Compare
Signed-off-by: jack.song <[email protected]>
shulanbushangshu
force-pushed
the
comm_tools
branch
from
8610c86 to
cf97c53
Compare
Signed-off-by: jack.song <[email protected]>
shulanbushangshu
force-pushed
the
comm_tools
branch
from
c18422e to
f8fb48e
Compare
Signed-off-by: jack.song <[email protected]>
shulanbushangshu
force-pushed
the
comm_tools
branch
from
8df0856 to
a3f0297
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
add common interface toold test
Tests performed
add common interface toold test
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.