feat: add function to create all channels

[lev-starkware]

Stack:

• feat: feat: adding main module #311
• feat: add functionality to create all servers #310
• feat: adding empty server and refactoring ComponentServer #309
• fix: change ComponentRunner start param to '&mut self' #308
• feat: add functionality to create all components #307
• feat: add function to create all clients #262
• feat: add function to create all channels #261 ⬅

⚠️ Part of a stack created by spr. Do not merge manually using the UI - doing so may have unexpected results.

---

This change is 

[Itay-Tsabary-Starkware]

Reviewable status: 0 of 1 files reviewed, 5 unresolved discussions (waiting on @lev-starkware)

---

crates/mempool_node/src/com_channels.rs line 4 at r1 (raw file):

use tokio::sync::mpsc::{channel, Receiver, Sender};

pub struct SingleChannel<T: Send + Sync> {

Please change this to ComponentCommunication.
Either in this pr, or in a refactoring pr in the end, and if the latter, please add a "todo" to address this issue here.

Code quote:

SingleChannel

---

crates/mempool_node/src/com_channels.rs line 5 at r1 (raw file):

pub struct SingleChannel<T: Send + Sync> {
    pub tx: Sender<T>,

Please change these to be private members, and have a get_tx and get_rx functions.

Also, not for this pr, but I suspect eventually we'll need to move ownership of the rx part to the server. It might make sense to change the definition here to Optional and use the take() function.

Code quote:

pub

---

crates/mempool_node/src/com_channels.rs line 9 at r1 (raw file):

}

pub struct CommChannels {

Please change this name to MempoolNodeCommunication.
Same comment regarding in which pr to do that (here / later -- add a todo).

Code quote:

CommChannels

---

crates/mempool_node/src/com_channels.rs line 10 at r1 (raw file):

pub struct CommChannels {
    pub mempool_channel: SingleChannel<MempoolRequestAndResponseSender>,

Ditto regarding visibility (pub) and getters.

Code quote:

pub

---

crates/mempool_node/src/com_channels.rs line 13 at r1 (raw file):

}

pub fn create_channels() -> CommChannels {

create_mempool_node_channels

Code quote:

create_channels

[Itay-Tsabary-Starkware]

Please rename the file to communication.rs

Reviewable status: 0 of 1 files reviewed, 5 unresolved discussions (waiting on @lev-starkware)

[Itay-Tsabary-Starkware]

Reviewable status: 0 of 1 files reviewed, 6 unresolved discussions (waiting on @lev-starkware)

---

-- commits line 1 at r1:
Please rename the file to communication.rs

[Itay-Tsabary-Starkware]

Reviewable status: 0 of 1 files reviewed, 6 unresolved discussions (waiting on @lev-starkware)

---

-- commits line 1 at r1:

Previously, Itay-Tsabary-Starkware wrote…

Please rename the file to communication.rs

Can be in a refactoring pr, if so, add a todo.

[Itay-Tsabary-Starkware]

Reviewable status: 0 of 1 files reviewed, 6 unresolved discussions (waiting on @lev-starkware)

---

crates/mempool_node/src/com_channels.rs line 13 at r1 (raw file):

Previously, Itay-Tsabary-Starkware wrote…

create_mempool_node_channels

Ignore the previous message, please rename to create_node_channels.

[lev-starkware]

Reviewable status: 0 of 1 files reviewed, 6 unresolved discussions (waiting on @Itay-Tsabary-Starkware)

---

-- commits line 1 at r1:

Previously, Itay-Tsabary-Starkware wrote…

Can be in a refactoring pr, if so, add a todo.

I don't like that name but Done.

---

crates/mempool_node/src/com_channels.rs line 4 at r1 (raw file):

Previously, Itay-Tsabary-Starkware wrote…

Please change this to ComponentCommunication.
Either in this pr, or in a refactoring pr in the end, and if the latter, please add a "todo" to address this issue here.

Done.

---

crates/mempool_node/src/com_channels.rs line 5 at r1 (raw file):

Previously, Itay-Tsabary-Starkware wrote…

Please change these to be private members, and have a get_tx and get_rx functions.

Also, not for this pr, but I suspect eventually we'll need to move ownership of the rx part to the server. It might make sense to change the definition here to Optional and use the take() function.

Done.

---

crates/mempool_node/src/com_channels.rs line 9 at r1 (raw file):

Previously, Itay-Tsabary-Starkware wrote…

Please change this name to MempoolNodeCommunication.
Same comment regarding in which pr to do that (here / later -- add a todo).

Done.

---

crates/mempool_node/src/com_channels.rs line 10 at r1 (raw file):

Previously, Itay-Tsabary-Starkware wrote…

Ditto regarding visibility (pub) and getters.

Done.

---

crates/mempool_node/src/com_channels.rs line 13 at r1 (raw file):

Previously, Itay-Tsabary-Starkware wrote…

Ignore the previous message, please rename to create_node_channels.

Done.

[Itay-Tsabary-Starkware]

Reviewed 2 of 2 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @lev-starkware)

[Itay-Tsabary-Starkware]

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @lev-starkware)

[Itay-Tsabary-Starkware]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @lev-starkware)

---

crates/mempool_node/src/communication.rs line 14 at r3 (raw file):

    }
    fn get_rx(&mut self) -> Receiver<T> {
        self.rx.take().expect("Receiver already taken")

Please change to the conventional expect format: "X should be Y".
For example, "Receiver should be available".

Code quote:

self.rx.take().expect("Receiver already taken")

[Itay-Tsabary-Starkware]

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @lev-starkware)

[Itay-Tsabary-Starkware]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @lev-starkware)

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.09%. Comparing base (7ea4039) to head (faf42aa).

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #261   +/-   ##
=======================================
  Coverage   85.09%   85.09%           
=======================================
  Files          28       28           
  Lines        1375     1375           
  Branches     1375     1375           
=======================================
  Hits         1170     1170           
  Misses        145      145           
  Partials       60       60           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Itay-Tsabary-Starkware]

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @lev-starkware)

[Itay-Tsabary-Starkware]

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @lev-starkware)

[lev-starkware]

✓ Commit merged in pull request #308