fix: change ComponentRunner start param to '&mut self' #289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 26, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## pr/lev-starkware/lev_dev/bb128e01 #289 +/- ##
==================================================================
Coverage 74.00% 74.00%
==================================================================
Files 30 30
Lines 1435 1435
Branches 1435 1435
==================================================================
Hits 1062 1062
Misses 318 318
Partials 55 55 ☔ View full report in Codecov by Sentry. |
lev-starkware
force-pushed
the
pr/lev-starkware/lev_dev/bb128e01
branch
from
eaac21e to
d19adbb
Compare
lev-starkware
force-pushed
the
pr/lev-starkware/lev_dev/6ec10946
branch
from
f5b41ad to
cec784a
Compare
lev-starkware
force-pushed
the
pr/lev-starkware/lev_dev/6ec10946
branch
from
cec784a to
bb0e379
Compare
lev-starkware
force-pushed
the
pr/lev-starkware/lev_dev/bb128e01
branch
from
d19adbb to
1ba1c91
Compare
lev-starkware
force-pushed
the
pr/lev-starkware/lev_dev/bb128e01
branch
from
1ba1c91 to
3d734de
Compare
lev-starkware
force-pushed
the
pr/lev-starkware/lev_dev/6ec10946
branch
from
bb0e379 to
ee19a52
Compare
Itay-Tsabary-Starkware
approved these changes
Jun 27, 2024
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @lev-starkware)
lev-starkware
force-pushed
the
pr/lev-starkware/lev_dev/6ec10946
branch
from
ee19a52 to
c583bb2
Compare
lev-starkware
force-pushed
the
pr/lev-starkware/lev_dev/bb128e01
branch
from
3d734de to
5b15998
Compare
commit-id:6ec10946
lev-starkware
force-pushed
the
pr/lev-starkware/lev_dev/bb128e01
branch
from
5b15998 to
609e1fd
Compare
lev-starkware
force-pushed
the
pr/lev-starkware/lev_dev/6ec10946
branch
from
c583bb2 to
d4af508
Compare
|
Closing pull request: commit has gone away |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack:
This change is