feat: add functionality to create all components

[lev-starkware]

Stack:

• feat: adding main module #292
• feat: add functionality to create all servers #291
• feat: adding empty server and refactoring ComponentServer #290
• fix: change ComponentRunner start param to '&mut self' #289
• feat: add functionality to create all components #265 ⬅
• feat: add function to create all clients #262
• feat: add function to create all channels #261

⚠️ Part of a stack created by spr. Do not merge manually using the UI - doing so may have unexpected results.

---

This change is 

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 0% with 23 lines in your changes missing coverage. Please review.

Project coverage is 74.00%. Comparing base (378d94d) to head (609e1fd).

Files	Patch %	Lines
crates/mempool_node/src/components.rs	0.00%	15 Missing ⚠️
crates/gateway/src/gateway.rs	0.00%	8 Missing ⚠️

Additional details and impacted files

@@                          Coverage Diff                          @@
##           pr/lev-starkware/lev_dev/414d7889     #265      +/-   ##
=====================================================================
- Coverage                              77.01%   74.00%   -3.01%     
=====================================================================
  Files                                     28       30       +2     
  Lines                                   1379     1435      +56     
  Branches                                1379     1435      +56     
=====================================================================
  Hits                                    1062     1062              
- Misses                                   262      318      +56     
  Partials                                  55       55              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Itay-Tsabary-Starkware]

Reviewable status: 0 of 5 files reviewed, 3 unresolved discussions (waiting on @lev-starkware)

---

crates/gateway/src/gateway.rs line 132 at r2 (raw file):

    config: GatewayConfig,
    rpc_state_reader_config: RpcStateReaderConfig,
    client: Option<SharedMempoolClient>,

When will this function be invoked with a None value for the client?
If never, please drop the Optional part, and change the type to Box<dyn MempoolClient -- we'd like to pass ownership of the client to this struct, not to share an atomic reference with all the other components that need a mempool-client.

Code quote:

Option<SharedMempoolClient>

---

crates/mempool_node/src/components.rs line 9 at r2 (raw file):

pub struct Components {
    pub gateway: Option<Gateway>,
    pub mempool: Option<Mempool>,

Please don't use pub visibility on fields unless there's an absolute must; that's not the case here imo.

Code quote:

    pub gateway: Option<Gateway>,
    pub mempool: Option<Mempool>,

---

crates/mempool_node/src/components.rs line 23 at r2 (raw file):

    if config.components.mempool_component.execute {
        components.mempool = Some(Mempool::empty());
    }

Please create each component as Some or None, and then bundle them together in the struct. That is, please do not create the struct with None values to begin with.

Code quote:

    let mut components = Components { gateway: None, mempool: None };
    if config.components.gateway_component.execute {
        components.gateway = Some(create_gateway(
            config.gateway_config.clone(),
            config.rpc_state_reader_config.clone(),
            clients.mempool_client.clone(),
        ));
    }
    if config.components.mempool_component.execute {
        components.mempool = Some(Mempool::empty());
    }

---

crates/mempool_node/src/lib.rs line 3 at r2 (raw file):

pub mod com_clients;
pub mod communication;
pub mod components;

Next time, please add these with at the relevant pr that introduces the new file.

Code quote:

pub mod com_clients;
pub mod communication;
pub mod components;

[lev-starkware]

Reviewable status: 0 of 5 files reviewed, 1 unresolved discussion (waiting on @Itay-Tsabary-Starkware)

---

crates/mempool_node/src/components.rs line 23 at r2 (raw file):

Previously, Itay-Tsabary-Starkware wrote…

Please create each component as Some or None, and then bundle them together in the struct. That is, please do not create the struct with None values to begin with.

Done.

[Itay-Tsabary-Starkware]

Reviewed 1 of 4 files at r2, 2 of 4 files at r3, all commit messages.
Reviewable status: 3 of 5 files reviewed, 2 unresolved discussions (waiting on @lev-starkware)

---

crates/mempool_node/src/components.rs line 14 at r3 (raw file):

pub fn create_components(config: &MempoolNodeConfig, clients: &MempoolNodeClients) -> Components {
    let gateway_component = if config.components.gateway_component.execute {
        let mempool_clent =

Typo (missing "i")

Code quote:

mempool_clent

[lev-starkware]

Closing pull request: commit has gone away