fix: change ComponentRunner start param to '&mut self' #308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 27, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## pr/lev-starkware/lev_dev/bb128e01 #308 +/- ##
==================================================================
Coverage 81.76% 81.76%
==================================================================
Files 30 30
Lines 1431 1431
Branches 1431 1431
==================================================================
Hits 1170 1170
Misses 201 201
Partials 60 60 ☔ View full report in Codecov by Sentry. |
lev-starkware
force-pushed
the
pr/lev-starkware/lev_dev/6ec10946
branch
2 times, most recently
from
3ee4a9d to
190eb60
Compare
Itay-Tsabary-Starkware
approved these changes
Jun 27, 2024
There was a problem hiding this comment.
Reviewed 1 of 2 files at r1.
Reviewable status: 1 of 2 files reviewed, all discussions resolved
lev-starkware
commented
Jun 30, 2024
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1.
Reviewable status: all files reviewed (commit messages unreviewed), all discussions resolved (waiting on @lev-starkware)
lev-starkware
commented
Jun 30, 2024
There was a problem hiding this comment.
Reviewed all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @lev-starkware)
lev-starkware
force-pushed
the
pr/lev-starkware/lev_dev/6ec10946
branch
from
190eb60 to
2b01d4c
Compare
commit-id:4cc36c62
commit-id:414d7889
commit-id:bb128e01
commit-id:6ec10946
lev-starkware
force-pushed
the
pr/lev-starkware/lev_dev/6ec10946
branch
from
2b01d4c to
eccc3e2
Compare
lev-starkware
force-pushed
the
pr/lev-starkware/lev_dev/bb128e01
branch
from
f2e11ad to
8d953cf
Compare
lev-starkware
changed the base branch from
pr/lev-starkware/lev_dev/bb128e01
to
main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
commit-id:6ec10946
Stack:
This change is