feat: feat: adding main module

[lev-starkware]

Stack:

• refactor: refactor integration tests to use mempool_node modules #339
• feat: feat: adding main module #311 ⬅
• feat: implementing ComponentRunner for the gateway #355

⚠️ Part of a stack created by spr. Do not merge manually using the UI - doing so may have unexpected results.

---

This change is 

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 0% with 52 lines in your changes missing coverage. Please review.

Project coverage is 78.47%. Comparing base (37d7bc8) to head (e89ace6).

Files	Patch %	Lines
crates/mempool_node/src/servers.rs	0.00%	31 Missing ⚠️
crates/mempool_node/src/main.rs	0.00%	21 Missing ⚠️

Additional details and impacted files

@@                          Coverage Diff                          @@
##           pr/lev-starkware/lev_dev/f9f21462     #311      +/-   ##
=====================================================================
- Coverage                              80.85%   78.47%   -2.38%     
=====================================================================
  Files                                     35       35              
  Lines                                   1619     1668      +49     
  Branches                                1619     1668      +49     
=====================================================================
  Hits                                    1309     1309              
- Misses                                   244      293      +49     
  Partials                                  66       66              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Itay-Tsabary-Starkware]

Reviewable status: 0 of 6 files reviewed, 2 unresolved discussions (waiting on @lev-starkware)

---

crates/gateway/src/gateway.rs line 85 at r1 (raw file):

            .with_state(self.app_state.clone())
    }
}

Please create a different pr solely for these changes.

Code quote:

    pub async fn run(&mut self) -> Result<(), GatewayRunError> {
        // Parses the bind address from GatewayConfig, returning an error for invalid addresses.
        let GatewayNetworkConfig { ip, port } = self.config.network_config;
        let addr = SocketAddr::new(ip, port);
        let app = self.app();

        // Create a server that runs forever.
        Ok(axum::Server::bind(&addr).serve(app.into_make_service()).await?)
    }

    pub fn app(&self) -> Router {
        Router::new()
            .route("/is_alive", get(is_alive))
            .route("/add_tx", post(add_tx))
            .with_state(self.app_state.clone())
    }
}

---

crates/gateway/src/gateway.rs line 208 at r1 (raw file):

            Ok(_) => Ok(()),
            Err(_) => Err(ComponentStartError::InternalComponentError),
        }

Please check out the map_err syntax, should be useful here.

Code quote:

        match self.run().await {
            Ok(_) => Ok(()),
            Err(_) => Err(ComponentStartError::InternalComponentError),
        }

[Itay-Tsabary-Starkware]

Reviewable status: 0 of 6 files reviewed, 3 unresolved discussions (waiting on @lev-starkware)

---

crates/mempool_node/src/main.rs line 12 at r1 (raw file):

#[tokio::main]
async fn main() -> anyhow::Result<()> {

Why is anyhow required here?

ChatGPT suggested the following, does this remove the need for the anyhow dependency?

use std::error::Error;

#[tokio::main]
async fn main() -> Result<(), Box<dyn Error>> {
    // Your async code here

    Ok(())
}

Code quote:

anyhow::Result<()>

[Itay-Tsabary-Starkware]

Reviewable status: 0 of 6 files reviewed, 4 unresolved discussions (waiting on @lev-starkware)

---

crates/mempool_node/src/main.rs line 14 at r1 (raw file):

async fn main() -> anyhow::Result<()> {
    let config = MempoolNodeConfig::load_and_process(args().collect());
    if let Err(ConfigError::CommandInput(clap_err)) = config {

What does this stand for?

Code quote:

clap_err

[Itay-Tsabary-Starkware]

Reviewable status: 0 of 6 files reviewed, 5 unresolved discussions (waiting on @lev-starkware)

---

crates/mempool_node/src/main.rs line 21 at r1 (raw file):

    if let Err(error) = config_validate(&config) {
        println!("Error: {}", error);
        exit(1);

Where does this error code originates from? Or was it an arbitrary choice?

Code quote:

exit(1);

[Itay-Tsabary-Starkware]

Reviewable status: 0 of 6 files reviewed, 6 unresolved discussions (waiting on @lev-starkware)

---

crates/mempool_node/src/main.rs line 32 at r1 (raw file):

    run_server_components(&config, servers).await?;

    Ok(())

This should never return, right?

[lev-starkware]

Reviewable status: 0 of 6 files reviewed, 6 unresolved discussions (waiting on @Itay-Tsabary-Starkware)

---

crates/mempool_node/src/main.rs line 12 at r1 (raw file):

Previously, Itay-Tsabary-Starkware wrote…

Why is anyhow required here?

ChatGPT suggested the following, does this remove the need for the anyhow dependency?

use std::error::Error;

#[tokio::main]
async fn main() -> Result<(), Box<dyn Error>> {
    // Your async code here

    Ok(())
}

This is how its done in the papyrus main.

---

crates/mempool_node/src/main.rs line 14 at r1 (raw file):

Previously, Itay-Tsabary-Starkware wrote…

What does this stand for?

I command line argument parsing error.

---

crates/mempool_node/src/main.rs line 21 at r1 (raw file):

Previously, Itay-Tsabary-Starkware wrote…

Where does this error code originates from? Or was it an arbitrary choice?

In case config validation returns error we cannot continue.

---

crates/mempool_node/src/main.rs line 32 at r1 (raw file):

Previously, Itay-Tsabary-Starkware wrote…

This should never return, right?

Right, but once more, went after papyrus main.

---

crates/gateway/src/gateway.rs line 85 at r1 (raw file):

Previously, Itay-Tsabary-Starkware wrote…

Please create a different pr solely for these changes.

Done.

---

crates/gateway/src/gateway.rs line 208 at r1 (raw file):

Previously, Itay-Tsabary-Starkware wrote…

Please check out the map_err syntax, should be useful here.

Done.

[Itay-Tsabary-Starkware]

Reviewed 2 of 6 files at r1, 4 of 4 files at r4, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @lev-starkware)

[uriel-starkware]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @lev-starkware)

---

crates/mempool_node/src/main.rs line 32 at r1 (raw file):

Previously, lev-starkware wrote…

Right, but once more, went after papyrus main.

if run\_server\_components(&config, servers).await returns the same result as main then no need for ?; and then Ok(()). Change to:

Code snippet:

run_server_components(&config, servers).await

[uriel-starkware]

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @lev-starkware)

[lev-starkware]

Reviewed 2 of 6 files at r1, 2 of 4 files at r4, 2 of 2 files at r5, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @lev-starkware)

[lev-starkware]

✓ Commit merged in pull request #339