-
-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(datapages): don't bind charts in the all charts block to the window #2921
Conversation
f109777
to
289d052
Compare
8f8bae5
to
b5ed8af
Compare
7198f8c
to
47f12ce
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thanks! I've rebased your changes onto the current version of the PR chain so that Sophia can easily release them all together when the time comes.
@sophiamersmann Also assigning this one your way now that Marcel's out. Update, merge or close it as you see fit once the other work is out. |
b4f02b3
to
5fc9af2
Compare
47f12ce
to
5f001dc
Compare
5fc9af2
to
fdad55d
Compare
5f001dc
to
c0651bf
Compare
fdad55d
to
4360f98
Compare
c0651bf
to
a4dc2d4
Compare
4360f98
to
598bb54
Compare
a4dc2d4
to
6ce3fd7
Compare
598bb54
to
7e4cf14
Compare
6ce3fd7
to
783f50f
Compare
7e4cf14
to
20f2fe7
Compare
783f50f
to
0e48356
Compare
20f2fe7
to
476f22c
Compare
0e48356
to
ae6fcc6
Compare
476f22c
to
a6a14fc
Compare
ae6fcc6
to
0c09402
Compare
a6a14fc
to
90a8043
Compare
0c09402
to
1d3e5a8
Compare
basically re-applying 7eb7096 (#2466)