Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(datapages): don't bind charts in the all charts block to the window #2921

Merged
merged 1 commit into from
Nov 27, 2023

Conversation

marcelgerber
Copy link
Member

basically re-applying 7eb7096 (#2466)

@marcelgerber marcelgerber requested a review from danyx23 November 12, 2023 17:58
@danyx23 danyx23 force-pushed the feat-sources-modal branch 2 times, most recently from 8f8bae5 to b5ed8af Compare November 17, 2023 15:54
@danyx23 danyx23 changed the base branch from feat-sources-modal to 11-09-improve-citation-block November 17, 2023 15:57
@danyx23 danyx23 force-pushed the fix-data-page-bind-window branch from 7198f8c to 47f12ce Compare November 17, 2023 16:11
Copy link
Contributor

@danyx23 danyx23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks! I've rebased your changes onto the current version of the PR chain so that Sophia can easily release them all together when the time comes.

@larsyencken
Copy link
Contributor

@sophiamersmann Also assigning this one your way now that Marcel's out. Update, merge or close it as you see fit once the other work is out.

@sophiamersmann sophiamersmann force-pushed the 11-09-improve-citation-block branch 3 times, most recently from b4f02b3 to 5fc9af2 Compare November 24, 2023 08:49
@sophiamersmann sophiamersmann force-pushed the fix-data-page-bind-window branch from 47f12ce to 5f001dc Compare November 24, 2023 08:49
@sophiamersmann sophiamersmann force-pushed the 11-09-improve-citation-block branch from 5fc9af2 to fdad55d Compare November 24, 2023 09:07
@sophiamersmann sophiamersmann force-pushed the fix-data-page-bind-window branch from 5f001dc to c0651bf Compare November 24, 2023 09:07
@sophiamersmann sophiamersmann force-pushed the 11-09-improve-citation-block branch from fdad55d to 4360f98 Compare November 24, 2023 10:44
@sophiamersmann sophiamersmann force-pushed the fix-data-page-bind-window branch from c0651bf to a4dc2d4 Compare November 24, 2023 10:44
@sophiamersmann sophiamersmann force-pushed the 11-09-improve-citation-block branch from 4360f98 to 598bb54 Compare November 24, 2023 12:02
@sophiamersmann sophiamersmann force-pushed the fix-data-page-bind-window branch from a4dc2d4 to 6ce3fd7 Compare November 24, 2023 12:02
@danyx23 danyx23 force-pushed the 11-09-improve-citation-block branch from 598bb54 to 7e4cf14 Compare November 24, 2023 16:50
@danyx23 danyx23 force-pushed the fix-data-page-bind-window branch from 6ce3fd7 to 783f50f Compare November 24, 2023 16:50
@danyx23 danyx23 force-pushed the 11-09-improve-citation-block branch from 7e4cf14 to 20f2fe7 Compare November 24, 2023 17:50
@danyx23 danyx23 force-pushed the fix-data-page-bind-window branch from 783f50f to 0e48356 Compare November 24, 2023 17:50
@sophiamersmann sophiamersmann force-pushed the 11-09-improve-citation-block branch from 20f2fe7 to 476f22c Compare November 24, 2023 19:58
@sophiamersmann sophiamersmann force-pushed the fix-data-page-bind-window branch from 0e48356 to ae6fcc6 Compare November 24, 2023 19:58
@sophiamersmann sophiamersmann force-pushed the 11-09-improve-citation-block branch from 476f22c to a6a14fc Compare November 24, 2023 20:03
@sophiamersmann sophiamersmann force-pushed the fix-data-page-bind-window branch from ae6fcc6 to 0c09402 Compare November 24, 2023 20:03
@danyx23 danyx23 force-pushed the 11-09-improve-citation-block branch from a6a14fc to 90a8043 Compare November 27, 2023 09:35
@danyx23 danyx23 force-pushed the fix-data-page-bind-window branch from 0c09402 to 1d3e5a8 Compare November 27, 2023 09:35
Copy link
Contributor

danyx23 commented Nov 27, 2023

Merge activity

  • Nov 27, 6:24 AM: @danyx23 started a stack merge that includes this pull request via Graphite.
  • Nov 27, 6:30 AM: @danyx23 merged this pull request with Graphite.

Base automatically changed from 11-09-improve-citation-block to master November 27, 2023 11:29
@danyx23 danyx23 merged commit e2900b1 into master Nov 27, 2023
12 checks passed
@danyx23 danyx23 deleted the fix-data-page-bind-window branch November 27, 2023 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants