Build sources modal from shared components

[sophiamersmann]

Description

Builds sources modal from shared components.

Handling of metadata:

• Source link(s) from old metadata
  • If a single source link is given, it is displayed in the "Link" field of the Key data block
  • If multiple source links are given, and they can be matched to their respective source, then the attributions are linkified (and no "Link" field is needed)
  • If multiple source links are given that cannot be matched to the sources, they're displayed in the "Links" field of the Key data block
• If given, old metadata is displayed as a single entry in the "This data is based on the following sources" Section
  • It's a single entry rather than multiple because the source description refers to all sources

Other changes:

• don't assume processing level is "minor" if no processing level is given

Known bugs:

• "Last updated" date is invalid because the catalog's version is "latest" (example chart)

[sophiamersmann]

Current dependencies on/for this PR:

• master
  • PR Data pages: show chart as full width #2879
    • PR ✨ Data pages: enable rendering of data pages on all eligible data pages, remove old datapage #2848
      • PR 🤹 Data pages: merge Sophia's changes to the about this data section #2880
      • PR 🎉 Add related research and writing via content graph to data pages #2739
        • PR Data page: About this data (& refactor shared components) #2853
          • PR Build sources modal from shared components #2877 👈
            • PR Sources modal: Multiple indicators #2886
              • PR Data page: About this data (updated design) #2914
                • PR Data page / Sources modal: Bug fixes #2918
                  • PR 🔨 restrict datapages to only charts with vars that have any description* set #2920
                  • PR 🔨 show default thumbnail if none is available #2922
                  • PR improve-citation-block #2929
                  • PR enhance: TextWrap opens and closes every HTML tag #2927
                  • PR fix(datapages): don't bind charts in the all charts block to the window #2921
                  • PR Data pages: final tweaks #2931

This stack of pull requests is managed by Graphite.

[danyx23]

Very nice! I had a few detail questions, but overall this is ready to go IMHO.

I saw that you used css variables in a few places which I don't think we use much so far - I have no opinion on this, but maybe worth chatting about in a grapher hour or so just to make sure we use the same tools for the same kinds of problems.

[danyx23]

I wonder if we should show this section expanded if we are in the "About this data" overlay? The data page is pretty long and shows a lot of stuff so the collapsed section makes sense, but if you want to see the sources then why make users click once more? I'm not 100% sure this is the best way forward but this is my hunch.

[sophiamersmann]

I think having the sources collapsed by default makes sense. Some of these fields can be quite long, e.g. click on "Bolt and van Zanden" in this chart. If that's the case the collapsed view gives a good overview of all sources in use.

[danyx23]

Merge activity

• Nov 27, 6:24 AM: @danyx23 started a stack merge that includes this pull request via Graphite.
• Nov 27, 6:26 AM: @danyx23 merged this pull request with Graphite.