Data pages: Incorporate bug bash feedback

[danyx23]

Sophia

• Make grapher a bit higher on wide screens (currently 600px and a 2.1 : 1 aspect ratio, try 700 px for 9 : 5)
• Now that we display markdown coming from the ETL in a few places we should make sure that if headings are used that these stay smaller than the headings they should logically have (e.g. an h1 heading in the sources description should not be larger than the heading denoting that source). Concretely:
  • Make all headings inside data page text blocks font size 1em, color #1D3D63, font-weight 700
  • Give them bigger margins above than below
  • Make sure paragraphs don't have too much space between them
• For the full citation, set the color to a lighter shade (Blue 50, #6E87A2). The full citation block should also use the markdown renderer so that links and markdown links are linkified.
• Clicking "Learn more about this data" on the chart should scroll down only to the "About this data" section, not all the way to the sources
• Bullet points in markdown in the sources etc don't show up correctly - e.g. the gapminder source text should have some visible bullet points here
• Make sure we use the en-dash instead of a hyphen for all texts we construct on the data page
• CSS Nits
  • Below "Retrieved on" there should be more space (slack with image)
  • The body text for "how we process data" should be Blue 60 (slack)
  • Use lining numerals in titles (slack)
  • Make the title "Reuse this work" align at the to with the paragraph (slack)
  • The heading for "Full citation" has too much space below (above and below are equal - slack)
• Update style of the "Read about our data pipeline button" (Slack)
• Sources tab design feedback from Marwa (in my DMs)

Daniel

• Decide on the inclusion criterion for creating data pages. Currently it is single indicator charts with schemaVersion == 2, but this pulls in a bunch of indicators where an origin was added to the dataset. Setting any of the description* or presentation fields might be better (but will rule out some charts that were deemed ok in the bug bash)
• Scatter plots should not render as data pages
• Improve citation blocks:
  • When assembling citations with things like titles, check if the title ends in an punctuation character like .?; — if so, don't append a period.
  • Attribution fragments and producers should be joined with ;
  • The year should only appear once - remove it after "processed by Our World in Data".
  • If using the titlePublic as the title of the page in the citation then add attributionShort and titleVariant
  • When falling back to producer, include the year (since attribution includes it)
  • Ensure that the attribution/producer text pieces in the full citation are unique
• The title is overridden with the grapher title of the first chart in the all charts block see this chart - fixed by Marcel in fix(datapages): don't bind charts in the all charts block to the window #2921
• Show a default thumbnail for the related research and writing section if there is no thumbnail for an article
• If there are many charts using an indicator (e.g. population) consider limiting them to only those that are tagged with an intersecting set of tags. Alternatively consider if the charts using query should only match on dimensions x and y
• Consider showing tags of articles in the related research and writing section?
• Show the topic pages of the tags that an indicator is tagged with in the related research and writing section

Undecided

• The copy icon is missing on all citation blocks should be okay - only happens on staging, I believe
• Consider: Individual sources in the "About this data" section should link to the right spot in the sources section
• Make sure data pages work on Safari (Este reported some weird issues)
• Expanded regions should unfold also by clicking on the faded text, not just the + icon
• (Sources modal) Weird formatting of bullet points in citation code block (http://staging-site-data-pages-final-tweaks/grapher/date-of-the-peak-cherry-tree-blossom-in-kyoto)
• Links not properly rendered (http://staging-site-data-pages-final-tweaks/grapher/life-expectancy; click on '"Zijdeman et al. – Life Expectancy at birth" in Sources & Processing Section)