Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Data page / Sources modal: Bug fixes #2918

Merged
merged 25 commits into from
Nov 27, 2023
Merged

Data page / Sources modal: Bug fixes #2918

merged 25 commits into from
Nov 27, 2023

Conversation

sophiamersmann
Copy link
Member

@sophiamersmann sophiamersmann commented Nov 9, 2023 •
edited
Loading

Addresses feedback and implements various bug fixes etc.

This was referenced Nov 9, 2023
Merged
Merged
Merged
Closed
Merged
Merged
Merged
@sophiamersmann
Copy link
Member Author

sophiamersmann commented Nov 9, 2023 •
edited by danyx23
Loading

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

@sophiamersmann sophiamersmann mentioned this pull request Nov 9, 2023
Merged
This was referenced Nov 12, 2023
Merged
Merged
@sophiamersmann sophiamersmann force-pushed the data-page-about-this-data branch from fbba85e to f03aedc Compare November 16, 2023 16:05
@danyx23 danyx23 force-pushed the data-page-about-this-data branch from f03aedc to 94e9e36 Compare November 16, 2023 17:01
@danyx23 danyx23 mentioned this pull request Nov 16, 2023
Merged
@danyx23 danyx23 force-pushed the data-page-about-this-data branch from 94e9e36 to 9378ac2 Compare November 17, 2023 15:54
This was referenced Nov 17, 2023
Merged
Merged
Merged
@sophiamersmann sophiamersmann force-pushed the data-page-about-this-data branch from 9378ac2 to 5b7f231 Compare November 23, 2023 16:18
@sophiamersmann sophiamersmann force-pushed the data-page-about-this-data branch from 5b7f231 to fa23246 Compare November 24, 2023 08:49
@sophiamersmann sophiamersmann force-pushed the data-page-about-this-data branch from fa23246 to 7ae21b2 Compare November 24, 2023 09:07
@sophiamersmann sophiamersmann force-pushed the data-page-about-this-data branch from 7ae21b2 to a645181 Compare November 24, 2023 12:02
@sophiamersmann @danyx23
enhance: use en dash instead of a hyphen
e3b13a2
@sophiamersmann @danyx23
refactor: simplify key data table
fcbe28e
@sophiamersmann @danyx23
enhance(sources-modal): add hover state for tabs
3b4aabc
@sophiamersmann @danyx23
refactor: move Tabs components into Grapher
eb68f60
@sophiamersmann @danyx23
fix: fix markdown rendering issues
0061361
@sophiamersmann @danyx23
feat(code-snippet): allow markdown text
b373d61
@sophiamersmann @danyx23
fix: address design feedback
1f18368
@sophiamersmann @danyx23
enhance: scroll to About this data section when clicking on sources
9a028c5
@sophiamersmann @danyx23
enhance(sources-modal): render Data published by as markdown
afe97ea
@sophiamersmann @danyx23
style(sources-modal): redesign key data table
7f3cf2a
@sophiamersmann @danyx23
enhance(sources-modal): show full tab label when possible
dfc6bee
@sophiamersmann @danyx23
enhance(sources-modal): restrict maximum width
6e16bc4
@sophiamersmann @danyx23
✨ (expandable) reduce bottom padding
ef54f83
@sophiamersmann @danyx23
✨ (sources-modal) improve wording
4f6fc62
@sophiamersmann @danyx23
✨ (sources-modal): deduplicate sources
f65ea8d
@sophiamersmann @danyx23
:sparkles (sources-modal) show loading indicator when not ready to re…
d44d7d1 
…nder
@sophiamersmann @danyx23
✨ (data-page) style content in expandables
a2c3dc1
@sophiamersmann @danyx23
💄 (data-page): remove debug code
d1ddbf3
@sophiamersmann @danyx23
✨ (sources-modal) avoid using expandable for sources with limited con…
f6c4bcc 
…tent
@sophiamersmann @danyx23
✨ (sources) hide processing phrase for owid data
a234893
@sophiamersmann @danyx23
✨ (sources-modal) hide source information of Continent variable
b4db9ef
@danyx23 danyx23 force-pushed the data-page-about-this-data branch from a645181 to 27562f0 Compare November 24, 2023 16:50
@danyx23 danyx23 marked this pull request as ready for review November 27, 2023 09:35
@danyx23 Graphite App
Copy link
Contributor

danyx23 commented Nov 27, 2023 •
edited
Loading

Merge activity

  • Nov 27, 6:24 AM: @danyx23 started a stack merge that includes this pull request via Graphite.
  • Nov 27, 6:28 AM: @danyx23 merged this pull request with Graphite.

Base automatically changed from data-page-about-this-data to master November 27, 2023 11:27
@danyx23 danyx23 merged commit d686996 into master Nov 27, 2023
12 checks passed
@danyx23 danyx23 deleted the sources-bug-fixes branch November 27, 2023 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sophiamersmann sophiamersmann

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sophiamersmann @danyx23