Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sources modal: Multiple indicators #2886

Merged
merged 27 commits into from
Nov 27, 2023
Merged

Sources modal: Multiple indicators #2886

merged 27 commits into from
Nov 27, 2023

Conversation

sophiamersmann
Copy link
Member

@sophiamersmann sophiamersmann commented Nov 2, 2023 •
edited
Loading

Displays expandable tabs for multiple indicators.

I haven't been very disciplined about pushing changes to the branches they belong to. So, this branch also contains various bug fixes that touch on data pages and the sources modal.

This was referenced Nov 2, 2023
Merged
Closed
Merged
@sophiamersmann
Copy link
Member Author

sophiamersmann commented Nov 2, 2023 •
edited by danyx23
Loading

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

@sophiamersmann sophiamersmann mentioned this pull request Nov 2, 2023
Merged
1 task
@sophiamersmann sophiamersmann mentioned this pull request Nov 2, 2023
Closed
4 tasks
@sophiamersmann sophiamersmann force-pushed the sources-multiple-indicators branch 3 times, most recently from 881f593 to 505d938 Compare November 3, 2023 10:27
@danyx23 danyx23 force-pushed the feat-sources-modal branch from 8e7f596 to e292ab1 Compare November 3, 2023 10:54
@danyx23 danyx23 force-pushed the sources-multiple-indicators branch from 505d938 to 4e25f11 Compare November 3, 2023 10:54
This was referenced Nov 3, 2023
Merged
Merged
Merged
Closed
@sophiamersmann sophiamersmann force-pushed the sources-multiple-indicators branch 5 times, most recently from 95c7e5d to bd75d68 Compare November 6, 2023 14:07
sophiamersmann
sophiamersmann commented Nov 7, 2023
View reviewed changes
packages/@ourworldindata/core-table/src/CoreTableColumns.ts Outdated
}

@imemo get displayName(): string {
return this.display?.name ?? this.name ?? ""
return this.display?.name || this.name || ""
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is why the svg tester comes back with a few updated charts

@sophiamersmann sophiamersmann force-pushed the sources-multiple-indicators branch from 3b5705c to 8c03d5c Compare November 7, 2023 10:49
@sophiamersmann sophiamersmann marked this pull request as ready for review November 7, 2023 10:51
@danyx23 danyx23 force-pushed the feat-sources-modal branch from 49dcc0a to 1b1ec94 Compare November 8, 2023 09:39
@danyx23 danyx23 force-pushed the sources-multiple-indicators branch from 74e1a18 to 05ccb05 Compare November 8, 2023 09:39
sophiamersmann and others added 24 commits November 24, 2023 17:45
@sophiamersmann @danyx23
enhance(sources-modal): only use expandable tabs if necessary
e53eabb
@sophiamersmann @danyx23
fix(sources-modal): fix hover state of expandable toggle
a247f8c
@sophiamersmann @danyx23
enhance(source-modal): sort y-columns by their display name
abeb261
@sophiamersmann @danyx23
enhance: programmaticaly focus active tab only for keyboard users
bec8bf5
@sophiamersmann @danyx23
fix(sources-modal): fix missing title
0b509a7
@sophiamersmann @danyx23
style(modal): place dismiss button consistently
62f9107
@sophiamersmann @danyx23
style(source-modal): fix spacing
e635d34
@sophiamersmann @danyx23
style(sources-modal): minor improvements
81f3a63
@sophiamersmann @danyx23
enhance: show unit conversion factor in key data block
c78a57e
@sophiamersmann @danyx23
fix: next update was in the past
f6d0e26
@sophiamersmann @danyx23
fix: fix date parsing error
8d53236
@sophiamersmann @danyx23
enhance(data-page): use source name in citation as a fallback
eb1142b
@sophiamersmann @danyx23
enhance(sources-modal): attach expandables to the key data table
0caf08e
@sophiamersmann @danyx23
enhance(sources-modal): improve modal on smaller screens
2ca4a28
@sophiamersmann @danyx23
enhance(source-modal): hide borders for a single key data item
c1853b9
@sophiamersmann @danyx23
fix: typescript error
4b35ce0
@sophiamersmann @danyx23
enhance(data-page): use source name in citation if origins are missing
9d2c5ee
@sophiamersmann @danyx23
enhance(sources-modal): improve on smaller screens
8c8d1f8
@sophiamersmann @danyx23
enhance(source-modal): render source link as markdown
5eb8908
@sophiamersmann @danyx23
chore: make eslint happy
0a56e72
@danyx23
🔨 fix rebase accident
b746fe2
@sophiamersmann @danyx23
fix: fix rebase issue regarding source metadata
d907dad
@sophiamersmann @danyx23
chore: make eslint happy
cafb694
@sophiamersmann @danyx23
🐛 (grapher) hide axis labels when appropriate
8fcf5c3
@danyx23 danyx23 force-pushed the sources-multiple-indicators branch from e758c6b to 8fcf5c3 Compare November 24, 2023 16:50
@danyx23 Graphite App
Copy link
Contributor

danyx23 commented Nov 27, 2023 •
edited
Loading

Merge activity

  • Nov 27, 6:24 AM: @danyx23 started a stack merge that includes this pull request via Graphite.
  • Nov 27, 6:27 AM: @danyx23 merged this pull request with Graphite.

Base automatically changed from feat-sources-modal to master November 27, 2023 11:26
@danyx23 danyx23 merged commit 99feeb6 into master Nov 27, 2023
10 checks passed
@danyx23 danyx23 deleted the sources-multiple-indicators branch November 27, 2023 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danyx23 danyx23 danyx23 requested changes

Assignees

@sophiamersmann sophiamersmann

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sophiamersmann @danyx23