Timeouts are not honored on Metal resources/data sources

[aayushrangwala]

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request.
• Please do not leave +1 or me too comments, they generate extra noise for issue followers and do not help prioritize the request.
• If you are interested in working on this issue or have submitted a pull request, please leave a comment.

Terraform Version

v1.5.4

Affected Resource(s)

• Metal Devices resource and datasource
• Metal ports
• Metal VRF
• Network Device
• SSH Key and a few more

Terraform Configuration Files

resource "equinix_metal_device" "device" {
  hostname         = "tf-device"
  plan             = var.plan
  metro            = var.metro
  operating_system = var.os
  billing_cycle    = "hourly"
  project_id       = var.project_id
#
  depends_on = [ equinix_metal_project_ssh_key.public_key ]

  timeouts {
    create = "5s"
  }
}

References

Some of the Metal resources/data sources (for example, the equinix_metal_device resource) indicate support for timeouts in their docs and schema, but do not actually support those timeouts.

Per terraform-plugin-sdk v2 docs, we should be using CreateContext, DeleteContext, etc. functions in order to have terraform automatically handle timeouts on our behalf: https://developer.hashicorp.com/terraform/plugin/sdkv2/guides/v2-upgrade-guide#more-support-for-context-context

Also, for the resources and datasources when the context aware timeouts would not be suitable, use Hashicorp's WaitForStateContext

We should find any Metal resources & data sources that have a Timeouts schema property and ensure that those resources & data sources use context-aware CRUD functions.

Tasks

Upgrade resources and data sources to support context aware or without context CRUD timeouts

• DataSource and Resource Metal Device support
• DataSource and Resource Metal Port support
• DataSource and Resource Metal Sport Market Request support
• DataSource and Resource Metal Virtual Circuit support
• DataSource and Resource Metal VRF support
• Resource Metal Reserved IP Block support
• Resource Network Device support