fix: Timeout for metal spot market requests #379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aayushrangwala
temporarily deployed
to
external
GitHub Actions
Inactive
|
@aayushrangwala could you add a Conventional Commits tag to the PR title? Tags are described in the comment above. For this I think |
7 tasks
aayushrangwala
force-pushed
the
timeout-fix-metal-spot-market-requests
branch
from
8e85937 to
7610e6f
Compare
aayushrangwala
temporarily deployed
to
external
GitHub Actions
Inactive
aayushrangwala
changed the title
@ctreatma Yes added fix |
aayushrangwala
requested a deployment
to
external
GitHub Actions
Abandoned
|
Based on the latest test run, all the timeout tests are passing |
aayushrangwala
requested a deployment
to
external
GitHub Actions
Abandoned
ctreatma
reviewed
Sep 25, 2023
equinix/data_source_metal_port.go
Outdated
| @@ -6,7 +6,7 @@ import ( | |||
|
|
|||
| func dataSourceMetalPort() *schema.Resource { | |||
| return &schema.Resource{ | |||
| Read: resourceMetalPortRead, | |||
| ReadWithoutTimeout: diagnosticsWrapper(resourceMetalPortRead), | |||
There was a problem hiding this comment.
Can these port changes be removed from this PR?
There was a problem hiding this comment.
Yes right. This branch got created out of the port changes.
aayushrangwala
force-pushed
the
timeout-fix-metal-spot-market-requests
branch
from
7610e6f to
72d7f2b
Compare
aayushrangwala
had a problem deploying
to
external
GitHub Actions
Error
aayushrangwala
force-pushed
the
timeout-fix-metal-spot-market-requests
branch
from
72d7f2b to
261a80b
Compare
aayushrangwala
temporarily deployed
to
external
GitHub Actions
Inactive
ctreatma
approved these changes
Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will fix the timeout support for metal spot market requests which is already documented publicly
relates to: #357