Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Timeout for metal network device #387

Closed
wants to merge 5 commits into from
Closed

fix: Timeout for metal network device #387

wants to merge 5 commits into from

Conversation

aayushrangwala
Copy link
Contributor

@aayushrangwala aayushrangwala temporarily deployed to external September 20, 2023 14:51 — with GitHub Actions Inactive
@aayushrangwala aayushrangwala mentioned this pull request Sep 20, 2023
Closed
7 tasks
@aayushrangwala aayushrangwala changed the title Timeout fix metal network device fix: Timeout for metal network device Sep 20, 2023
ctreatma
ctreatma reviewed Sep 20, 2023
View reviewed changes
Copy link
Contributor

@ctreatma ctreatma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are Network Edge resources, not Metal resources, and they're not covered by tests, so I think it would be preferable to leave them as-is and work with the Network Edge team to fix them when they have capacity to work with us.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ctreatma ctreatma ctreatma left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aayushrangwala @ctreatma