Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Timeout for metal virtual circuits #380

Merged

Conversation

aayushrangwala
Copy link
Contributor

@aayushrangwala aayushrangwala commented Sep 14, 2023

@aayushrangwala aayushrangwala temporarily deployed to external September 14, 2023 16:01 — with GitHub Actions Inactive
@codecov-commenter
Copy link

codecov-commenter commented Sep 14, 2023

Codecov Report

Patch coverage: 73.91% and project coverage change: +45.54% 🎉

Comparison is base (973fdaa) 13.73% compared to head (0aa1287) 59.27%.
Report is 5 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #380       +/-   ##
===========================================
+ Coverage   13.73%   59.27%   +45.54%     
===========================================
  Files           8       98       +90     
  Lines         910    19753    +18843     
===========================================
+ Hits          125    11709    +11584     
- Misses        770     7750     +6980     
- Partials       15      294      +279     
Files Changed Coverage Δ
equinix/fabric_mapping_helper.go 0.80% <0.00%> (ø)
equinix/resource_metal_virtual_circuit.go 76.57% <86.66%> (ø)
equinix/data_source_metal_virtual_circuit.go 100.00% <100.00%> (ø)
equinix/fabric_connection_schema.go 100.00% <100.00%> (ø)

... and 86 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ctreatma
Copy link
Contributor

@aayushrangwala could you add a Conventional Commits tag to the PR title? Tags are described in the comment above. For this I think fix: would make sense but a different one might work.

@aayushrangwala aayushrangwala force-pushed the timeout-fix-metal-virtual-circuits branch from 46b8e66 to 0aa1287 Compare September 20, 2023 14:49
@aayushrangwala aayushrangwala temporarily deployed to external September 20, 2023 14:49 — with GitHub Actions Inactive
@aayushrangwala aayushrangwala changed the title Timeout fix metal virtual circuits Fix: Timeouts for metal virtual circuits Sep 20, 2023
@aayushrangwala aayushrangwala changed the title Fix: Timeouts for metal virtual circuits fix: Timeouts for metal virtual circuits Sep 20, 2023
@aayushrangwala aayushrangwala changed the title fix: Timeouts for metal virtual circuits fix: Timeout fixformetal virtual circuits Sep 20, 2023
@aayushrangwala aayushrangwala changed the title fix: Timeout fixformetal virtual circuits fix: Timeout for metal virtual circuits Sep 20, 2023
@aayushrangwala aayushrangwala requested a deployment to external September 20, 2023 21:00 — with GitHub Actions Abandoned
@aayushrangwala
Copy link
Contributor Author

@aayushrangwala could you add a Conventional Commits tag to the PR title? Tags are described in the comment above. For this I think fix: would make sense but a different one might work.

yes added fix for all the related PRs

@ctreatma ctreatma merged commit 985603b into equinix:main Sep 22, 2023
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants