fix: Update CRUD for metal port to support timeouts

[aayushrangwala]

• Adds support for timeout in Create, update and delete operation.
• Adds acceptance tests

Fixes #357

[codecov-commenter]

Codecov Report

Attention: 14 lines in your changes are missing coverage. Please review.

Comparison is base (973fdaa) 13.73% compared to head (383679e) 60.14%.
Report is 33 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@             Coverage Diff             @@
##             main     #377       +/-   ##
===========================================
+ Coverage   13.73%   60.14%   +46.40%     
===========================================
  Files           8       98       +90     
  Lines         910    19758    +18848     
===========================================
+ Hits          125    11883    +11758     
- Misses        770     7575     +6805     
- Partials       15      300      +285     

Files	Coverage Δ
equinix/data_source_metal_port.go	100.00% <100.00%> (ø)
equinix/data_source_metal_virtual_circuit.go	100.00% <100.00%> (ø)
equinix/fabric_connection_schema.go	100.00% <100.00%> (ø)
equinix/resource_metal_port.go	89.84% <100.00%> (ø)
equinix/resource_metal_reserved_ip_block.go	84.23% <100.00%> (ø)
equinix/resource_metal_vrf.go	86.40% <100.00%> (ø)
equinix/data_source_metal_vrf.go	89.58% <33.33%> (ø)
equinix/resource_metal_virtual_circuit.go	76.57% <86.66%> (ø)
equinix/fabric_mapping_helper.go	0.80% <0.00%> (ø)
equinix/port_helpers.go	77.33% <81.81%> (ø)

... and 80 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[ctreatma]

In the latest CI run I see that a bunch of tests are failing due to timeouts right around the 20 minute mark: https://github.com/equinix/terraform-provider-equinix/actions/runs/6251976162/job/16974235659?pr=377#step:5:3981

I'm not clear on whether those timeouts are expected or not, or if we need to increase a default timeout interval somewhere.

[aayushrangwala]

In the latest CI run I see that a bunch of tests are failing due to timeouts right around the 20 minute mark: https://github.com/equinix/terraform-provider-equinix/actions/runs/6251976162/job/16974235659?pr=377#step:5:3981

I'm not clear on whether those timeouts are expected or not, or if we need to increase a default timeout interval somewhere.

Yes those are failing but they are not expected to fail. In the terraform resource schema we had 20min default timeout but still it seems thats not enough. Trying to update it with 30m probably

Also, I am not sure a port should take more than 20m or 30m ideally to be created. Since we introduced the usage of the declared timeouts in this PRs, thats what caused the tests for fail

[aayushrangwala]

Details

Based on this new test run the metal port timeout specific tests are all passing. Hence it suggests that the overall Acceptances tests may be a bit flaky only sometimes

[ctreatma]

Based on this new test run the metal port timeout specific tests are all passing. Hence it suggests that the overall Acceptances tests may be a bit flaky only sometimes

I see both FAIL: TestAccMetalPortUpdate_hybridBonded_timeout and FAIL: TestAccMetalPortCreate_hybridBonded_timeout in the linked test run, as well as in the previous run.

[aayushrangwala]

Tests specific to ports are passing now after changing the default timeout to 30 minutes