-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade metal device resource and data source to use timeouts #364
Merged
ctreatma
merged 4 commits into
equinix:main
from
aayushrangwala:timeout-fix-metal-device
Aug 30, 2023
Merged
Upgrade metal device resource and data source to use timeouts #364
ctreatma
merged 4 commits into
equinix:main
from
aayushrangwala:timeout-fix-metal-device
Aug 30, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aayushrangwala
force-pushed
the
timeout-fix-metal-device
branch
2 times, most recently
from
August 23, 2023 02:16
fa9d102
to
c458c7b
Compare
ctreatma
reviewed
Aug 23, 2023
ctreatma
reviewed
Aug 23, 2023
aayushrangwala
force-pushed
the
timeout-fix-metal-device
branch
from
August 23, 2023 18:53
d70b765
to
f3725b4
Compare
ctreatma
reviewed
Aug 24, 2023
ctreatma
reviewed
Aug 24, 2023
aayushrangwala
force-pushed
the
timeout-fix-metal-device
branch
2 times, most recently
from
August 28, 2023 16:28
e949259
to
03b19c7
Compare
ctreatma
reviewed
Aug 28, 2023
aayushrangwala
force-pushed
the
timeout-fix-metal-device
branch
from
August 28, 2023 17:55
03b19c7
to
0f76dd9
Compare
ctreatma
reviewed
Aug 28, 2023
aayushrangwala
force-pushed
the
timeout-fix-metal-device
branch
from
August 30, 2023 14:10
9ed778f
to
4ebf329
Compare
ctreatma
approved these changes
Aug 30, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see the new tests passing in CI:
7 tasks
aayushrangwala
added a commit
to aayushrangwala/terraform-provider-equinix
that referenced
this pull request
Sep 7, 2023
…x#364) Provides support for timeouts in Create, Update and Delete for Metal Device as already mentioned in the documents
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provides support for timeouts in Create, Update and Delete for Metal Device as already mentioned in the documents
#357