Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(component_interface_specs): prefix package and namespace with autoware #9094

Merged

Conversation

esteve
Copy link
Contributor

@esteve esteve commented Oct 16, 2024

Description

prefix package and namespace with autoware

Related links

Parent Issue:

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:common Common packages from the autoware-common repository. (auto-assigned) labels Oct 16, 2024
Copy link

github-actions bot commented Oct 16, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@esteve esteve force-pushed the prefix-component_interface_specs branch from 55835e4 to 0e9c316 Compare October 16, 2024 11:37
@github-actions github-actions bot added component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned) component:localization Vehicle's position determination in its environment. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) component:control Vehicle control algorithms and mechanisms. (auto-assigned) component:system System design and integration. (auto-assigned) component:map Map creation, storage, and loading. (auto-assigned) tag:require-cuda-build-and-test labels Oct 16, 2024
@esteve
Copy link
Contributor Author

esteve commented Oct 16, 2024

This PR depends on tier4/tier4_ad_api_adaptor#126

@esteve esteve enabled auto-merge (squash) October 16, 2024 11:39
@esteve esteve added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Oct 16, 2024
@esteve esteve force-pushed the prefix-component_interface_specs branch from ff0ed49 to 8b357dd Compare October 16, 2024 12:00
Copy link

codecov bot commented Oct 16, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 28.63%. Comparing base (9bd0f77) to head (8700bca).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
system/autoware_default_adapi/src/vehicle_door.cpp 0.00% 2 Missing ⚠️
system/autoware_default_adapi/src/motion.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9094      +/-   ##
==========================================
- Coverage   28.63%   28.63%   -0.01%     
==========================================
  Files        1312     1313       +1     
  Lines      101648   101651       +3     
  Branches    39464    39465       +1     
==========================================
  Hits        29110    29110              
- Misses      69614    69617       +3     
  Partials     2924     2924              
Flag Coverage Δ *Carryforward flag
differential 28.17% <0.00%> (?)
total 28.63% <ø> (+<0.01%) ⬆️ Carriedforward from 9bd0f77

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@isamu-takagi
Copy link
Contributor

@esteve Thank you. Could you please update to use autoware::component_interface_specs::<module> instead of autoware::component_interface_specs::<module>_interface, as the original namespace has become redundant with the addition of the package name? Or I'll update it next week when I can work on it.

@esteve esteve marked this pull request as draft October 21, 2024 22:27
auto-merge was automatically disabled October 21, 2024 22:27

Pull request was converted to draft

@esteve
Copy link
Contributor Author

esteve commented Oct 21, 2024

@isamu-takagi thanks for the review. I've moved this PR back to draft so that I'll make the changes you requested.

@esteve esteve marked this pull request as ready for review October 21, 2024 22:44
@esteve
Copy link
Contributor Author

esteve commented Oct 21, 2024

@isamu-takagi this is now ready for review again

Copy link
Contributor

@isamu-takagi isamu-takagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. I checked autonomous driving using the planning simulator.

@SakodaShintaro
Copy link
Contributor

Sorry, I missed your comment #9094 (comment)

Copy link
Contributor

@SakodaShintaro SakodaShintaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have confirmed that logging_simulator with sample_rosbag works well.
LGTM for localization and map.

@esteve esteve enabled auto-merge (squash) October 25, 2024 11:58
@esteve
Copy link
Contributor Author

esteve commented Oct 25, 2024

@isamu-takagi @SakodaShintaro thank you very much for your review

@xmfcx @mitsudome-r given that @isamu-takagi approved this PR and he's one of the maintainers of the autoware_component_interface_specs package, would it be ok to merge this PR without waiting for all the other reviewers who are code owners of downstream packages? Thanks

@mitsudome-r mitsudome-r added tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) and removed tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) labels Oct 28, 2024
@xmfcx xmfcx force-pushed the prefix-component_interface_specs branch from d9a495b to 8700bca Compare October 29, 2024 07:59
@xmfcx
Copy link
Contributor

xmfcx commented Oct 29, 2024

Combined with:

On my machine, I was able to build and test successfully.
Summary: 246 packages finished [16min 40s]

Even if the codebuild CI fails, we can merge this.

@xmfcx xmfcx disabled auto-merge October 29, 2024 09:22
@xmfcx
Copy link
Contributor

xmfcx commented Oct 29, 2024

@xmfcx xmfcx merged commit 589fee4 into autowarefoundation:main Oct 29, 2024
31 of 32 checks passed
@esteve esteve deleted the prefix-component_interface_specs branch October 29, 2024 09:32
esteve added a commit to esteve/autoware.universe that referenced this pull request Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:common Common packages from the autoware-common repository. (auto-assigned) component:control Vehicle control algorithms and mechanisms. (auto-assigned) component:localization Vehicle's position determination in its environment. (auto-assigned) component:map Map creation, storage, and loading. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned) component:system System design and integration. (auto-assigned) tag:require-cuda-build-and-test tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:documentation Creating or refining documentation. (auto-assigned)
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

5 participants