-
Notifications
You must be signed in to change notification settings - Fork 658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(component_interface_specs): prefix package and namespace with autoware #9094
refactor(component_interface_specs): prefix package and namespace with autoware #9094
Conversation
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
55835e4
to
0e9c316
Compare
This PR depends on tier4/tier4_ad_api_adaptor#126 |
ff0ed49
to
8b357dd
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9094 +/- ##
==========================================
- Coverage 28.63% 28.63% -0.01%
==========================================
Files 1312 1313 +1
Lines 101648 101651 +3
Branches 39464 39465 +1
==========================================
Hits 29110 29110
- Misses 69614 69617 +3
Partials 2924 2924
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@esteve Thank you. Could you please update to use |
Pull request was converted to draft
@isamu-takagi thanks for the review. I've moved this PR back to draft so that I'll make the changes you requested. |
@isamu-takagi this is now ready for review again |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you. I checked autonomous driving using the planning simulator.
Sorry, I missed your comment #9094 (comment) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have confirmed that logging_simulator
with sample_rosbag works well.
LGTM for localization and map.
@isamu-takagi @SakodaShintaro thank you very much for your review @xmfcx @mitsudome-r given that @isamu-takagi approved this PR and he's one of the maintainers of the |
…h autoware Signed-off-by: Esteve Fernandez <[email protected]>
Signed-off-by: Esteve Fernandez <[email protected]>
d9a495b
to
8700bca
Compare
Combined with: On my machine, I was able to build and test successfully. Even if the codebuild CI fails, we can merge this. |
@mitsudome-r with: The CI has passed. |
…h autoware (autowarefoundation#9094) Signed-off-by: Esteve Fernandez <[email protected]>
Description
prefix package and namespace with autoware
Related links
Parent Issue:
autoware.universe/common
packages autoware#5077How was this PR tested?
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.