fix(autoware_velocity_smoother): fix duplicateBreak warning

[veqcc]

Description

This is a fix based on cppcheck duplicateBreak warning

planning/autoware_velocity_smoother/src/node.cpp:1016:3: style: Consecutive return, break, continue, goto or throw statements are unnecessary. [duplicateBreak]
  return AlgorithmType::INVALID;
  ^

Related links

Parent Issue:

• Link

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

[github-actions]

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

• You've checked our contribution guidelines.
• Your PR follows our pull request guidelines.
• All required CI checks pass before marking the PR ready for review.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 18.07%. Comparing base (507e3f4) to head (3f1307e).
Report is 145 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #7699       +/-   ##
===========================================
+ Coverage   14.84%   18.07%    +3.22%     
===========================================
  Files        1999      485     -1514     
  Lines      139163    38936   -100227     
  Branches    43716    11125    -32591     
===========================================
- Hits        20661     7038    -13623     
+ Misses      95731    30915    -64816     
+ Partials    22771      983    -21788     

Flag	Coverage Δ
differential	18.07% <ø> (?)
total	?

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[TakaHoribe]

I didn't know this code causes an error message, but this fix makes sense to me.

[rej55]

LGTM!

[veqcc]

@TakaHoribe

I didn't know this code causes an error message

This is because throw std::domain_error("[VelocitySmootherNode] undesired algorithm is selected."); will exit the code and the following return AlgorithmType::INVALID; will not be executed.
The warning duplicateBreak means ""Consecutive return, break, continue, goto or throw statements are unnecessary"" (cited from https://github.com/danmar/cppcheck/blob/1668b0b689885b703039af1eb27c76da77f6445d/lib/checkother.cpp#L893 )