Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): remove unnecessary cppcheck suppressions #7677

Merged
merged 3 commits into from
Jun 27, 2024

Conversation

veqcc
Copy link
Contributor

@veqcc veqcc commented Jun 25, 2024

Description

Could be merged after #7671 is merged.

Related links

Parent Issue:

  • Link

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@veqcc veqcc requested a review from kminoda June 25, 2024 05:39
@veqcc veqcc self-assigned this Jun 25, 2024
@veqcc veqcc added type:ci Continuous Integration (CI) processes and testing. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) labels Jun 25, 2024
Signed-off-by: Ryuta Kambe <[email protected]>
@github-actions github-actions bot removed the type:ci Continuous Integration (CI) processes and testing. (auto-assigned) label Jun 26, 2024
Copy link

github-actions bot commented Jun 26, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@veqcc veqcc added the type:ci Continuous Integration (CI) processes and testing. (auto-assigned) label Jun 26, 2024
Signed-off-by: Ryuta Kambe <[email protected]>
@github-actions github-actions bot removed the type:ci Continuous Integration (CI) processes and testing. (auto-assigned) label Jun 26, 2024
@xmfcx
Copy link
Contributor

xmfcx commented Jun 26, 2024

Could you provide an example within this repository where each of these is unnecessary?

@veqcc veqcc merged commit 49ec490 into autowarefoundation:main Jun 27, 2024
25 checks passed
@veqcc veqcc deleted the update_cppcheck branch June 27, 2024 12:15
mitukou1109 pushed a commit to mitukou1109/autoware.universe that referenced this pull request Jul 2, 2024
…on#7677)

* chore(ci): remove unnecessary cppcheck suppressions

Signed-off-by: Ryuta Kambe <[email protected]>

* remove constVariable

Signed-off-by: Ryuta Kambe <[email protected]>

* remove duplicateBreak

Signed-off-by: Ryuta Kambe <[email protected]>

---------

Signed-off-by: Ryuta Kambe <[email protected]>
palas21 pushed a commit to palas21/autoware.universe that referenced this pull request Jul 12, 2024
…on#7677)

* chore(ci): remove unnecessary cppcheck suppressions

Signed-off-by: Ryuta Kambe <[email protected]>

* remove constVariable

Signed-off-by: Ryuta Kambe <[email protected]>

* remove duplicateBreak

Signed-off-by: Ryuta Kambe <[email protected]>

---------

Signed-off-by: Ryuta Kambe <[email protected]>
Signed-off-by: palas21 <[email protected]>
tby-udel pushed a commit to tby-udel/autoware.universe that referenced this pull request Jul 14, 2024
…on#7677)

* chore(ci): remove unnecessary cppcheck suppressions

Signed-off-by: Ryuta Kambe <[email protected]>

* remove constVariable

Signed-off-by: Ryuta Kambe <[email protected]>

* remove duplicateBreak

Signed-off-by: Ryuta Kambe <[email protected]>

---------

Signed-off-by: Ryuta Kambe <[email protected]>
KhalilSelyan pushed a commit that referenced this pull request Jul 22, 2024
* chore(ci): remove unnecessary cppcheck suppressions

Signed-off-by: Ryuta Kambe <[email protected]>

* remove constVariable

Signed-off-by: Ryuta Kambe <[email protected]>

* remove duplicateBreak

Signed-off-by: Ryuta Kambe <[email protected]>

---------

Signed-off-by: Ryuta Kambe <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants