-
Notifications
You must be signed in to change notification settings - Fork 660
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(raw_vehicle_cmd_converter)!: prefix package and namespace with autoware #7385
refactor(raw_vehicle_cmd_converter)!: prefix package and namespace with autoware #7385
Conversation
02c4a07
to
4054438
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -1,7 +1,7 @@ | |||
<?xml version="1.0" encoding="UTF-8"?> | |||
<launch> | |||
<arg name="accel_brake_map_calib_param" default="$(find-pkg-share accel_brake_map_calibrator)/config/accel_brake_map_calibrator.param.yaml"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@takayuki5168
[just a single comment]
I understand that this PR doesn't include accel_brake_map_calibrator
's change. But its change will be necessary later.
<arg name="accel_brake_map_calib_param" default="$(find-pkg-share accel_brake_map_calibrator)/config/accel_brake_map_calibrator.param.yaml"/>
@takayuki5168 FYi, since cppcheck-differential was made required just now, please fix the following items (see here) vehicle/autoware_raw_vehicle_cmd_converter/include/autoware_raw_vehicle_cmd_converter/pid.hpp:45:3: warning: Member variable 'PIDController::kp_' is not initialized. [uninitMemberVarPrivate] |
Signed-off-by: Takayuki Murooka <[email protected]>
Signed-off-by: Takayuki Murooka <[email protected]>
Signed-off-by: Takayuki Murooka <[email protected]>
4054438
to
8a836b2
Compare
Signed-off-by: Takayuki Murooka <[email protected]>
Signed-off-by: Takayuki Murooka <[email protected]>
…th autoware (#7385) * add prefix Signed-off-by: Takayuki Murooka <[email protected]> * fix other packages Signed-off-by: Takayuki Murooka <[email protected]> * fix cppcheck Signed-off-by: Takayuki Murooka <[email protected]> * pre-commit Signed-off-by: Takayuki Murooka <[email protected]> * fix Signed-off-by: Takayuki Murooka <[email protected]> --------- Signed-off-by: Takayuki Murooka <[email protected]>
Description
This PR adds the autoware_ prefix to the package and puts headers in the autoware namespace.
Part of:
autowarefoundation/autoware#4569
This PR has to be merged with autowarefoundation/autoware_launch#1021
Tests performed
psim
Effects on system behavior
Nothing
Interface changes
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.