Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(raw_vehicle_cmd_converter)!: prefix package and namespace with autoware #7385

Conversation

takayuki5168
Copy link
Contributor

@takayuki5168 takayuki5168 commented Jun 8, 2024

Description

This PR adds the autoware_ prefix to the package and puts headers in the autoware namespace.

Part of:
autowarefoundation/autoware#4569

This PR has to be merged with autowarefoundation/autoware_launch#1021

Tests performed

psim

Effects on system behavior

Nothing

Interface changes

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:vehicle Vehicle-specific implementations, drivers, packages. (auto-assigned) type:ci Continuous Integration (CI) processes and testing. (auto-assigned) component:launch Launch files, scripts and initialization tools. (auto-assigned) labels Jun 8, 2024
@takayuki5168 takayuki5168 force-pushed the feat/autoware-prefix-raw-vehicle-cmd branch from 02c4a07 to 4054438 Compare June 8, 2024 17:26
@takayuki5168 takayuki5168 marked this pull request as ready for review June 8, 2024 17:26
@takayuki5168 takayuki5168 added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jun 8, 2024
Copy link
Contributor

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -1,7 +1,7 @@
<?xml version="1.0" encoding="UTF-8"?>
<launch>
<arg name="accel_brake_map_calib_param" default="$(find-pkg-share accel_brake_map_calibrator)/config/accel_brake_map_calibrator.param.yaml"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@takayuki5168
[just a single comment]
I understand that this PR doesn't include accel_brake_map_calibrator 's change. But its change will be necessary later.

  <arg name="accel_brake_map_calib_param" default="$(find-pkg-share accel_brake_map_calibrator)/config/accel_brake_map_calibrator.param.yaml"/>

@kminoda
Copy link
Contributor

kminoda commented Jun 10, 2024

@takayuki5168 FYi, since cppcheck-differential was made required just now, please fix the following items (see here)

vehicle/autoware_raw_vehicle_cmd_converter/include/autoware_raw_vehicle_cmd_converter/pid.hpp:45:3: warning: Member variable 'PIDController::kp_' is not initialized. [uninitMemberVarPrivate]
double kp_;
^
vehicle/autoware_raw_vehicle_cmd_converter/include/autoware_raw_vehicle_cmd_converter/pid.hpp:46:3: warning: Member variable 'PIDController::ki_' is not initialized. [uninitMemberVarPrivate]
double ki_;
^
vehicle/autoware_raw_vehicle_cmd_converter/include/autoware_raw_vehicle_cmd_converter/pid.hpp:47:3: warning: Member variable 'PIDController::kd_' is not initialized. [uninitMemberVarPrivate]
double kd_;
^
vehicle/autoware_raw_vehicle_cmd_converter/include/autoware_raw_vehicle_cmd_converter/pid.hpp:48:3: warning: Member variable 'PIDController::max_ret_p_' is not initialized. [uninitMemberVarPrivate]
double max_ret_p_;
^
vehicle/autoware_raw_vehicle_cmd_converter/include/autoware_raw_vehicle_cmd_converter/pid.hpp:49:3: warning: Member variable 'PIDController::min_ret_p_' is not initialized. [uninitMemberVarPrivate]
double min_ret_p_;
^
vehicle/autoware_raw_vehicle_cmd_converter/include/autoware_raw_vehicle_cmd_converter/pid.hpp:50:3: warning: Member variable 'PIDController::max_ret_i_' is not initialized. [uninitMemberVarPrivate]
double max_ret_i_;
^
vehicle/autoware_raw_vehicle_cmd_converter/include/autoware_raw_vehicle_cmd_converter/pid.hpp:51:3: warning: Member variable 'PIDController::min_ret_i_' is not initialized. [uninitMemberVarPrivate]
double min_ret_i_;
^
vehicle/autoware_raw_vehicle_cmd_converter/include/autoware_raw_vehicle_cmd_converter/pid.hpp:52:3: warning: Member variable 'PIDController::max_ret_d_' is not initialized. [uninitMemberVarPrivate]
double max_ret_d_;
^
vehicle/autoware_raw_vehicle_cmd_converter/include/autoware_raw_vehicle_cmd_converter/pid.hpp:53:3: warning: Member variable 'PIDController::min_ret_d_' is not initialized. [uninitMemberVarPrivate]
double min_ret_d_;
^
vehicle/autoware_raw_vehicle_cmd_converter/include/autoware_raw_vehicle_cmd_converter/pid.hpp:54:3: warning: Member variable 'PIDController::max_ret_' is not initialized. [uninitMemberVarPrivate]
double max_ret_;
^
vehicle/autoware_raw_vehicle_cmd_converter/include/autoware_raw_vehicle_cmd_converter/pid.hpp:55:3: warning: Member variable 'PIDController::min_ret_' is not initialized. [uninitMemberVarPrivate]
double min_ret_;
^

Signed-off-by: Takayuki Murooka <[email protected]>
Signed-off-by: Takayuki Murooka <[email protected]>
Signed-off-by: Takayuki Murooka <[email protected]>
@takayuki5168 takayuki5168 force-pushed the feat/autoware-prefix-raw-vehicle-cmd branch from 4054438 to 8a836b2 Compare June 10, 2024 06:37
@takayuki5168 takayuki5168 merged commit 7d81b7c into autowarefoundation:main Jun 10, 2024
23 of 24 checks passed
@takayuki5168 takayuki5168 deleted the feat/autoware-prefix-raw-vehicle-cmd branch June 10, 2024 10:29
KhalilSelyan pushed a commit that referenced this pull request Jul 22, 2024
…th autoware (#7385)

* add prefix

Signed-off-by: Takayuki Murooka <[email protected]>

* fix other packages

Signed-off-by: Takayuki Murooka <[email protected]>

* fix cppcheck

Signed-off-by: Takayuki Murooka <[email protected]>

* pre-commit

Signed-off-by: Takayuki Murooka <[email protected]>

* fix

Signed-off-by: Takayuki Murooka <[email protected]>

---------

Signed-off-by: Takayuki Murooka <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:launch Launch files, scripts and initialization tools. (auto-assigned) component:vehicle Vehicle-specific implementations, drivers, packages. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:ci Continuous Integration (CI) processes and testing. (auto-assigned) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants