refactor(external cmd converter)!: add autoware_ prefix #7361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
type:documentation
yuki-takagi-66
force-pushed
the
prefix-external_cmd_converter
branch
from
ade5d0a to
6502765
Compare
yuki-takagi-66
added
the
tag:run-build-and-test-differential
takayuki5168
approved these changes
Jun 10, 2024
Signed-off-by: Yuki Takagi <[email protected]>
Signed-off-by: Yuki Takagi <[email protected]>
Signed-off-by: Yuki Takagi <[email protected]>
Signed-off-by: Yuki Takagi <[email protected]>
Signed-off-by: Yuki Takagi <[email protected]>
yuki-takagi-66
force-pushed
the
prefix-external_cmd_converter
branch
from
b7f1437 to
b2c48a7
Compare
| @@ -244,9 +244,8 @@ system/system_monitor/** [email protected] [email protected] | |||
| system/topic_state_monitor/** [email protected] | |||
| system/velodyne_monitor/** [email protected] | |||
| tools/reaction_analyzer/** [email protected] | |||
| vehicle/autoware_steer_offset_estimator/** [email protected] | |||
There was a problem hiding this comment.
removed this because it is already defined in another place.
KhalilSelyan
pushed a commit
that referenced
this pull request
Jul 22, 2024
* add prefix to the code Signed-off-by: Yuki Takagi <[email protected]> * rename Signed-off-by: Yuki Takagi <[email protected]> * fix Signed-off-by: Yuki Takagi <[email protected]> * fix Signed-off-by: Yuki Takagi <[email protected]> * fix Signed-off-by: Yuki Takagi <[email protected]> * Update .github/CODEOWNERS --------- Signed-off-by: Yuki Takagi <[email protected]> Co-authored-by: Takayuki Murooka <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add
autoware_prefix toexternal cmd converter.Part of:
Related links
autowarefoundation/autoware#4569
Tests performed
We can launch the node by
ros2 launch autoware_external_cmd_converter external_cmd_converter.launch.xmlwith no error.Effects on system behavior
Not applicable.
Interface changes
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.