Skip to content

Commit

Permalink
fix
Browse files Browse the repository at this point in the history
Signed-off-by: Yuki Takagi <[email protected]>
  • Loading branch information
yuki-takagi-66 committed Jun 10, 2024
1 parent 3383e0c commit 6502765
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 6 deletions.
5 changes: 4 additions & 1 deletion launch/tier4_control_launch/launch/control.launch.py
Original file line number Diff line number Diff line change
Expand Up @@ -290,7 +290,10 @@ def launch_setup(context, *args, **kwargs):
# external cmd converter
external_cmd_converter_loader = IncludeLaunchDescription(
PythonLaunchDescriptionSource(
[FindPackageShare("autoware_external_cmd_converter"), "/launch/external_cmd_converter.launch.py"]
[
FindPackageShare("autoware_external_cmd_converter"),
"/launch/external_cmd_converter.launch.py",
]

Check warning on line 296 in launch/tier4_control_launch/launch/control.launch.py

View check run for this annotation

CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main)

❌ Getting worse: Large Method

launch_setup increases from 373 to 376 lines of code, threshold = 70. Large functions with many lines of code are generally harder to understand and lower the code health. Avoid adding more lines to this function.
),
launch_arguments=[
("use_intra_process", LaunchConfiguration("use_intra_process")),
Expand Down
2 changes: 1 addition & 1 deletion launch/tier4_control_launch/package.xml
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,11 @@
<buildtool_depend>ament_cmake_auto</buildtool_depend>
<buildtool_depend>autoware_cmake</buildtool_depend>

<exec_depend>autoware_external_cmd_converter</exec_depend>
<exec_depend>autoware_external_cmd_selector</exec_depend>
<exec_depend>autoware_lane_departure_checker</exec_depend>
<exec_depend>autoware_vehicle_cmd_gate</exec_depend>
<exec_depend>control_evaluator</exec_depend>
<exec_depend>autoware_external_cmd_converter</exec_depend>
<exec_depend>external_cmd_selector</exec_depend>
<exec_depend>shift_decider</exec_depend>
<exec_depend>trajectory_follower_node</exec_depend>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@
// See the License for the specific language governing permissions and
// limitations under the License.

#ifndef AUTOWARE_EXTERNAL_CMD_CONVERTER__NODE_HPP_
#define AUTOWARE_EXTERNAL_CMD_CONVERTER__NODE_HPP_
#ifndef EXTERNAL_CMD_CONVERTER__NODE_HPP_
#define EXTERNAL_CMD_CONVERTER__NODE_HPP_

#include <diagnostic_updater/diagnostic_updater.hpp>
#include <raw_vehicle_cmd_converter/accel_map.hpp>
Expand Down Expand Up @@ -101,4 +101,4 @@ class ExternalCmdConverterNode : public rclcpp::Node

} // namespace autoware::external_cmd_converter

#endif // AUTOWARE_EXTERNAL_CMD_CONVERTER__NODE_HPP_
#endif // EXTERNAL_CMD_CONVERTER__NODE_HPP_
2 changes: 1 addition & 1 deletion vehicle/autoware_external_cmd_converter/src/node.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
// See the License for the specific language governing permissions and
// limitations under the License.

#include "external_cmd_converter/node.hpp"
#include "autoware_external_cmd_converter/node.hpp"

#include <algorithm>
#include <memory>
Expand Down

0 comments on commit 6502765

Please sign in to comment.