feat: add autoware_remaining_distance_time_calculator and overlay #6855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
component:planning
7 tasks
ahmeddesokyebrahim
force-pushed
the
4593-feat-remaining-distance-eta
branch
7 times, most recently
from
1600450 to
fc6a81c
Compare
ahmeddesokyebrahim
force-pushed
the
4593-feat-remaining-distance-eta
branch
from
fc6a81c to
44e7c51
Compare
github-actions
bot
added
type:documentation
ahmeddesokyebrahim
force-pushed
the
4593-feat-remaining-distance-eta
branch
2 times, most recently
from
d0c2ed2 to
ad9cca8
Compare
7 tasks
ahmeddesokyebrahim
changed the title
ahmeddesokyebrahim
requested review from
rej55,
kosuke55,
kyoichi-sugahara,
satoshi-ota,
shmpwk,
TakaHoribe,
takayuki5168,
TomohitoAndo,
tkimura4,
zulfaqar-azmi-t4 and
mkuri
as code owners
2024-05-11.00-30-42.mp4I've fixed the anchoring too. Now all the position and size adjustments work properly. |
2024-05-11.00-34-26.mp4Visualization part is finished, it works well. The ETA calculation is so bad. |
added 2 commits
May 11, 2024 00:52
Signed-off-by: M. Fatih Cırıt <[email protected]>
Signed-off-by: M. Fatih Cırıt <[email protected]>
xmfcx
force-pushed
the
4593-feat-remaining-distance-eta
branch
from
66cb9b5 to
42611d6
Compare
Signed-off-by: M. Fatih Cırıt <[email protected]>
Signed-off-by: M. Fatih Cırıt <[email protected]>
xmfcx
force-pushed
the
4593-feat-remaining-distance-eta
branch
from
5cacfa1 to
3b2957f
Compare
|
Applied the max_velocity to the remaining time calculation. It now estimates the remaining time more stable and reliable. In the following test, with 2 red lights:
|
Signed-off-by: M. Fatih Cırıt <[email protected]>
|
Bottom right side was looking a bit emptier than the bottom left side. So I've enlarged the inner rect to account for visual gap. |
xmfcx
approved these changes
May 11, 2024
Signed-off-by: M. Fatih Cırıt <[email protected]>
xmfcx
changed the title
Signed-off-by: Ahmed Ebrahim <[email protected]>
… to find proper route by maintaining last valid remaining dist and time Signed-off-by: Ahmed Ebrahim <[email protected]>
Signed-off-by: Ahmed Ebrahim <[email protected]>
…ntended division by zero or negative time values / update readme Signed-off-by: Ahmed Ebrahim <[email protected]> feat(remaining_dist_eta): add check for velocity limit preventing unintended division by zero or negative time values / update readme Signed-off-by: Ahmed Ebrahim <[email protected]>
Signed-off-by: Ahmed Ebrahim <[email protected]>
vividf
pushed a commit
to vividf/autoware.universe
that referenced
this pull request
May 16, 2024
…towarefoundation#6855) Signed-off-by: AhmedEbrahim <[email protected]> Signed-off-by: M. Fatih Cırıt <[email protected]> Signed-off-by: vividf <[email protected]>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
Jun 3, 2024
…towarefoundation#6855) Signed-off-by: AhmedEbrahim <[email protected]> Signed-off-by: M. Fatih Cırıt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to add a the implementation needed for mission remaining distance and estimated time of arrival (ETA)
Related links
Part of:
Depends on :
Used by :
Tests performed
Notes for reviewers
For successful compilation and testing, please take into consideration ..
Interface changes
Effects on system behavior
Along with the autoware_internal_ msgs PR and autoware_launch PR, Autoware will have the feature to report the mission remaining mission distance and estimated time left
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.