Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(remaining_dist_eta): add MissionDetailsDisplay plugin rviz configuration #963

Conversation

ahmeddesokyebrahim
Copy link
Contributor

@ahmeddesokyebrahim ahmeddesokyebrahim commented Apr 23, 2024

Description

This PR aims to add a the implementation needed for mission remaining mission distance and estimated time of arrival (ETA) (or estimated time left)

Related links

Part of:

Depends on :

Tests performed

Please check the tests performed in autoware.universe PR

Notes for reviewers

For successful compilation and testing, please take into consideration the msg definition in autoware_internal_msgs PR and the implementation in autoware.universe PR.

Interface changes

Adding rviz plugin for displaying mission details (remaining distance and time)

Effects on system behavior

Along with the autoware.universe PR and autoware_internal_msgs PR , Autoware will have the feature to report the mission remaining distance and time.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Ahmed Ebrahim added 3 commits May 10, 2024 17:18
…ode into autoware.rviz to have the display relevant to top right corner

Signed-off-by: AhmedEbrahim <[email protected]>
@xmfcx xmfcx force-pushed the autoware/launch/4593-feat-remaining-distance-eta branch from e9a1523 to 76e5a9f Compare May 10, 2024 14:18
M. Fatih Cırıt added 2 commits May 10, 2024 19:33
Signed-off-by: M. Fatih Cırıt <[email protected]>
Signed-off-by: M. Fatih Cırıt <[email protected]>
Copy link
Contributor

@xmfcx xmfcx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2024-05-13.11-57-52.mp4

Works well!

@xmfcx xmfcx merged commit f145420 into autowarefoundation:main May 13, 2024
12 of 13 checks passed
Ericpotato pushed a commit to tier4/autoware_launch that referenced this pull request Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants