feat(route_handler): use start pose yaw and not lanelet length to select start lanelet #6550
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main)
succeeded
Mar 6, 2024 in 40s
CodeScene PR Check
✅ Code Health Quality Gates: OK
- Declining Code Health: 0 findings(s) 🚩
- Improving Code Health: 2 findings(s) ✅
- Affected Hotspots: 0 files(s) 🔥
Recommended Review Level: Detailed -- Increased risk for defects: The risk is higher as much of the code in this repo (99% of all commits) is written by other authors.
View detailed results in CodeScene
Details
✅ Improving Code Health:
- Lines of Code in a Single File route_handler.cpp
- Bumpy Road Ahead route_handler.cpp: RouteHandler::planPathLaneletsBetweenCheckpoints
Annotations
Check notice on line 1 in planning/route_handler/src/route_handler.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
✅ Getting better: Lines of Code in a Single File
The lines of code decreases from 1911 to 1900, improve code health by reducing it to 1000. The number of Lines of Code in a single file. More Lines of Code lowers the code health.
Check notice on line 2178 in planning/route_handler/src/route_handler.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
✅ Getting better: Bumpy Road Ahead
RouteHandler::planPathLaneletsBetweenCheckpoints decreases from 4 to 3 logical blocks with deeply nested code, threshold is one single block per function. The Bumpy Road code smell is a function that contains multiple chunks of nested conditional logic. The deeper the nesting and the more bumps, the lower the code health.
Loading