Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(goal_planner): revert "refactor(goal_planner): rebuild state transition (#5371)" #5399

Merged
merged 1 commit into from
Oct 25, 2023

fix(goal_planner): revert "refactor(goal_planner): rebuild state tran…

1c979e8
Select commit
Loading
Failed to load commit list.
Merged

fix(goal_planner): revert "refactor(goal_planner): rebuild state transition (#5371)" #5399

fix(goal_planner): revert "refactor(goal_planner): rebuild state tran…
1c979e8
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) succeeded Oct 24, 2023 in 47s

CodeScene PR Check

Code Health Quality Gates: OK

  • Declining Code Health: 0 findings(s) 🚩
  • Improving Code Health: 1 findings(s) ✅
  • Affected Hotspots: 1 files(s) 🔥

Recommended Review Level: Detailed -- Increased risk for defects: The risk is higher as much of the code in this repo (99% of all commits) is written by other authors.
View detailed results in CodeScene

Details

✅ Improving Code Health:

  • Overall Code Complexity goal_planner_module.cpp 🔥

Annotations

Check notice on line 1 in planning/behavior_path_planner/src/scene_module/goal_planner/goal_planner_module.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

ℹ Getting worse: Lines of Code in a Single File

The lines of code increases from 1352 to 1367, improve code health by reducing it to 1000. The number of Lines of Code in a single file. More Lines of Code lowers the code health.

Check notice on line 1 in planning/behavior_path_planner/src/scene_module/goal_planner/goal_planner_module.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

✅ Getting better: Overall Code Complexity

The mean cyclomatic complexity decreases from 4.35 to 4.33, threshold = 4. This file has many conditional statements (e.g. if, for, while) across its implementation, leading to lower code health. Avoid adding more conditionals.