-
Notifications
You must be signed in to change notification settings - Fork 668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(goal_planner): revert "refactor(goal_planner): rebuild state transition (#5371)" #5399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kosuke55
requested review from
rej55,
kyoichi-sugahara,
satoshi-ota,
shmpwk,
taikitanaka3,
TakaHoribe,
takayuki5168,
tkimura4,
purewater0901 and
zulfaqar-azmi-t4
as code owners
October 24, 2023 11:37
github-actions
bot
added
the
component:planning
Route planning, decision-making, and navigation. (auto-assigned)
label
Oct 24, 2023
kosuke55
added
the
run:build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
label
Oct 24, 2023
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #5399 +/- ##
=======================================
Coverage 14.80% 14.80%
=======================================
Files 1661 1661
Lines 115448 115455 +7
Branches 35642 35641 -1
=======================================
+ Hits 17093 17096 +3
- Misses 79109 79114 +5
+ Partials 19246 19245 -1
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
kyoichi-sugahara
approved these changes
Oct 25, 2023
kosuke55
added a commit
to tier4/autoware.universe
that referenced
this pull request
Oct 25, 2023
…sition (autowarefoundation#5371)" (autowarefoundation#5399) This reverts commit 3d2a7f6.
4 tasks
rej55
added a commit
to tier4/autoware.universe
that referenced
this pull request
Oct 25, 2023
fix(goal_planner): revert "refactor(goal_planner): rebuild state transition (autowarefoundation#5371)" (autowarefoundation#5399)
kosuke55
added a commit
that referenced
this pull request
Oct 26, 2023
kosuke55
added a commit
that referenced
this pull request
Oct 26, 2023
kosuke55
added a commit
that referenced
this pull request
Oct 26, 2023
kosuke55
added a commit
that referenced
this pull request
Oct 27, 2023
kosuke55
added a commit
that referenced
this pull request
Oct 27, 2023
…5417) * refactor(goal_planner): rebuild state transition (#5371)" (#5399)" This reverts commit 92f78a4. * fix: increment path idx Signed-off-by: kosuke55 <[email protected]> * refactor Signed-off-by: kosuke55 <[email protected]> --------- Signed-off-by: kosuke55 <[email protected]>
HansOersted
pushed a commit
that referenced
this pull request
Nov 14, 2023
…5417) * refactor(goal_planner): rebuild state transition (#5371)" (#5399)" This reverts commit 92f78a4. * fix: increment path idx Signed-off-by: kosuke55 <[email protected]> * refactor Signed-off-by: kosuke55 <[email protected]> --------- Signed-off-by: kosuke55 <[email protected]> Signed-off-by: Zhe Shen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component:planning
Route planning, decision-making, and navigation. (auto-assigned)
run:build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 3d2a7f6.
Description
dismiss degradation
#5371 (comment)
Tests performed
Not applicable.
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.