Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(goal_planner): revert "refactor(goal_planner): rebuild state transition (#5371)" #5399

Merged
merged 1 commit into from
Oct 25, 2023

Conversation

kosuke55
Copy link
Contributor

@kosuke55 kosuke55 commented Oct 24, 2023

This reverts commit 3d2a7f6.

Description

dismiss degradation
#5371 (comment)

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Oct 24, 2023
@kosuke55 kosuke55 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Oct 24, 2023
@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

Attention: 15 lines in your changes are missing coverage. Please review.

Comparison is base (db27686) 14.80% compared to head (1c979e8) 14.80%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5399   +/-   ##
=======================================
  Coverage   14.80%   14.80%           
=======================================
  Files        1661     1661           
  Lines      115448   115455    +7     
  Branches    35642    35641    -1     
=======================================
+ Hits        17093    17096    +3     
- Misses      79109    79114    +5     
+ Partials    19246    19245    -1     
Flag Coverage Δ *Carryforward flag
differential 12.33% <28.57%> (?)
total 14.80% <ø> (-0.01%) ⬇️ Carriedforward from db27686

*This pull request uses carry forward flags. Click here to find out more.

Files Coverage Δ
.../scene_module/goal_planner/goal_planner_module.hpp 28.30% <0.00%> (-0.55%) ⬇️
.../scene_module/goal_planner/goal_planner_module.cpp 5.70% <31.57%> (+0.19%) ⬆️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kosuke55 kosuke55 merged commit 92f78a4 into main Oct 25, 2023
37 of 39 checks passed
@kosuke55 kosuke55 deleted the fix/revert_goal_planner_rebuild branch October 25, 2023 02:39
kosuke55 added a commit to tier4/autoware.universe that referenced this pull request Oct 25, 2023
rej55 added a commit to tier4/autoware.universe that referenced this pull request Oct 25, 2023
fix(goal_planner): revert "refactor(goal_planner): rebuild state transition (autowarefoundation#5371)" (autowarefoundation#5399)
kosuke55 added a commit that referenced this pull request Oct 25, 2023
kosuke55 added a commit that referenced this pull request Oct 26, 2023
kosuke55 added a commit that referenced this pull request Oct 26, 2023
kosuke55 added a commit that referenced this pull request Oct 26, 2023
kosuke55 added a commit that referenced this pull request Oct 27, 2023
kosuke55 added a commit that referenced this pull request Oct 27, 2023
…5417)

* refactor(goal_planner): rebuild state transition (#5371)" (#5399)"

This reverts commit 92f78a4.

* fix: increment path idx

Signed-off-by: kosuke55 <[email protected]>

* refactor

Signed-off-by: kosuke55 <[email protected]>

---------

Signed-off-by: kosuke55 <[email protected]>
HansOersted pushed a commit that referenced this pull request Nov 14, 2023
…5417)

* refactor(goal_planner): rebuild state transition (#5371)" (#5399)"

This reverts commit 92f78a4.

* fix: increment path idx

Signed-off-by: kosuke55 <[email protected]>

* refactor

Signed-off-by: kosuke55 <[email protected]>

---------

Signed-off-by: kosuke55 <[email protected]>
Signed-off-by: Zhe Shen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants