refactor(localization_error_monitor): rename localization_accuracy #5178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motsu-san
added
the
component:localization
github-actions
bot
added
component:system
7 tasks
7 tasks
Merged
4 tasks
|
This pull request has been automatically marked as stale because it has not had recent activity. |
Motsu-san
force-pushed
the
3065-rename-localization_accuracy
branch
from
1c821d6 to
a7c022c
Compare
Motsu-san
requested review from
ito-san,
KeisukeShima,
kminoda and
YamatoAndo
as code owners
YamatoAndo
approved these changes
Jan 5, 2024
Motsu-san
force-pushed
the
3065-rename-localization_accuracy
branch
from
a7c022c to
75c791c
Compare
|
@KeisukeShima Could you please review this pull-request? |
KeisukeShima
approved these changes
Jan 17, 2024
Motsu-san
force-pushed
the
3065-rename-localization_accuracy
branch
2 times, most recently
from
a7c022c to
aa5073e
Compare
Motsu-san
force-pushed
the
3065-rename-localization_accuracy
branch
from
aa5073e to
cc55c40
Compare
Motsu-san
requested review from
KYabuuchi,
RyuYamamoto,
SakodaShintaro and
TaikiYamada4
as code owners
to localization_error_ellipse Signed-off-by: Motsu-san <[email protected]>
Motsu-san
force-pushed
the
3065-rename-localization_accuracy
branch
from
cc55c40 to
c8948bd
Compare
ito-san
added
the
run:build-and-test-differential
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5178 +/- ##
=======================================
Coverage 14.58% 14.58%
=======================================
Files 1871 1871
Lines 127544 127544
Branches 37310 37310
=======================================
Hits 18608 18608
Misses 88017 88017
Partials 20919 20919
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
anhnv3991
pushed a commit
to anhnv3991/autoware.universe
that referenced
this pull request
Jan 29, 2024
…utowarefoundation#5178) refactor: Rename localization_accuracy to localization_error_ellipse Signed-off-by: Motsu-san <[email protected]> Signed-off-by: anhnv3991 <[email protected]>
kyoichi-sugahara
pushed a commit
to kyoichi-sugahara/autoware.universe
that referenced
this pull request
Jan 29, 2024
…utowarefoundation#5178) refactor: Rename localization_accuracy to localization_error_ellipse Signed-off-by: Motsu-san <[email protected]>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
Jun 3, 2024
…utowarefoundation#5178) refactor: Rename localization_accuracy to localization_error_ellipse Signed-off-by: Motsu-san <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
This is for the issue #3065
This must be merged simultaneously with autowarefoundation/autoware_launch#605 .
Contents
Rename "localization_accuracy" to localization_error_ellipse
Tests performed
It was confirmed that Build is OK.
Effects on system behavior
Start to display
localization_error_ellipseinstead oflocalization_accuracy.Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.