-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(system_error_monitor): rename localization_accuracy #605
Merged
Motsu-san
merged 1 commit into
autowarefoundation:main
from
Motsu-san:3065-rename-localization_accuracy
Jan 26, 2024
Merged
refactor(system_error_monitor): rename localization_accuracy #605
Motsu-san
merged 1 commit into
autowarefoundation:main
from
Motsu-san:3065-rename-localization_accuracy
Jan 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
7 tasks
Motsu-san
changed the title
refactor: Rename localization_accuracy
refactor(system_error_monitor): Rename localization_accuracy
Sep 29, 2023
Motsu-san
added
component:localization
Vehicle's position determination in its environment. (auto-assigned)
component:system
System design and integration. (auto-assigned)
component:simulation
Virtual environment setups and simulations. (auto-assigned)
labels
Sep 29, 2023
TomohitoAndo
pushed a commit
to TomohitoAndo/autoware_launch.awf
that referenced
this pull request
Oct 20, 2023
) Signed-off-by: Takayuki Murooka <[email protected]> Signed-off-by: Takayuki Murooka <[email protected]>
This pull request has been automatically marked as stale because it has not had recent activity. |
Motsu-san
force-pushed
the
3065-rename-localization_accuracy
branch
from
January 4, 2024 07:55
7f0a12f
to
3c95a54
Compare
Motsu-san
force-pushed
the
3065-rename-localization_accuracy
branch
from
January 4, 2024 08:02
3c95a54
to
00edfcb
Compare
to localization_error_ellipse Signed-off-by: Motsu-san <[email protected]>
Motsu-san
force-pushed
the
3065-rename-localization_accuracy
branch
from
January 18, 2024 04:17
00edfcb
to
6c4f530
Compare
Motsu-san
changed the title
refactor(system_error_monitor): Rename localization_accuracy
refactor(system_error_monitor): rename localization_accuracy
Jan 18, 2024
@ito-san Could you review this pull request? |
ito-san
approved these changes
Jan 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This was referenced Jan 26, 2024
maxime-clem
pushed a commit
to maxime-clem/autoware_launch
that referenced
this pull request
Feb 6, 2024
chore: sync awf/autoware_launch
maxime-clem
pushed a commit
to maxime-clem/autoware_launch
that referenced
this pull request
May 21, 2024
…handler * feat: add option to launch mrm handler (autowarefoundation#929) Signed-off-by: Takagi, Isamu <[email protected]> * chore: add option to select graph path depending on running mode (autowarefoundation#938) chore: add option of using graph path for simulation Signed-off-by: Tomohito Ando <[email protected]> * feat: add a param file of a mrm handler node (autowarefoundation#927) Signed-off-by: TetsuKawa <[email protected]> * feat: update config to launch mrm_handler Signed-off-by: Tomohito Ando <[email protected]> * feat(mrm_handler): enable comfortable stop Signed-off-by: Tomohito Ando <[email protected]> --------- Signed-off-by: Takagi, Isamu <[email protected]> Signed-off-by: Tomohito Ando <[email protected]> Signed-off-by: TetsuKawa <[email protected]> Co-authored-by: Takagi, Isamu <[email protected]> Co-authored-by: TetsuKawa <[email protected]>
Kazunori-Nakajima
pushed a commit
to Kazunori-Nakajima/autoware_launch
that referenced
this pull request
Oct 17, 2024
chore: sync awf-latest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component:localization
Vehicle's position determination in its environment. (auto-assigned)
component:simulation
Virtual environment setups and simulations. (auto-assigned)
component:system
System design and integration. (auto-assigned)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
This is for the issue autowarefoundation/autoware.universe#3065
This must be merged simultaneously with autowarefoundation/autoware.universe#5178 .
Contents
Rename "localization_accuracy" to localization_error_ellipse
Tests performed
It was confirmed that Build is OK.
Effects on system behavior
Start to display
localization_error_ellipse
instead oflocalization_accuracy
.Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.