-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: use snapi class info in process declare tx #516
refactor: use snapi class info in process declare tx #516
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @ArniStarkware and the rest of your teammates on Graphite |
9a5d8bd
to
a5af9bc
Compare
b38f6d8
to
a5fa529
Compare
a5af9bc
to
65e6550
Compare
a5fa529
to
7a53f19
Compare
65e6550
to
70056e5
Compare
70056e5
to
b0a4971
Compare
b0a4971
to
10fc2e9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 4 files at r1, 2 of 2 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ArniStarkware, @ayeletstarkware, @MohammadNassar1, and @yair-starkware)
crates/gateway/src/compilation_test.rs
line 105 at r3 (raw file):
let class_info = gateway_compiler.process_declare_tx(&declare_tx).unwrap(); assert_eq!(class_info.sierra_program_length, sierra_program_length);
Please add also an assertion for the casm_contract_class
.
10fc2e9
to
6bc63b8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 3 of 5 files reviewed, 1 unresolved discussion (waiting on @ayeletstarkware, @dafnamatsry, @MohammadNassar1, and @yair-starkware)
crates/gateway/src/compilation_test.rs
line 105 at r3 (raw file):
Previously, dafnamatsry wrote…
Please add also an assertion for the
casm_contract_class
.
Done.
This is enough - it hard to compare the entire contract class is as expected. It is enough to see the result casm contract class has the expected hash.
6bc63b8
to
5aa7df9
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #516 +/- ##
=======================================
Coverage 76.60% 76.60%
=======================================
Files 348 348
Lines 36771 36768 -3
Branches 36771 36768 -3
=======================================
- Hits 28167 28165 -2
- Misses 6281 6283 +2
+ Partials 2323 2320 -3 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 4 of 4 files at r4, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @ayeletstarkware, @MohammadNassar1, and @yair-starkware)
During the function process_tx in the gateway, the compilation (sierra to casm) occurs.
In this PR, we change the compilation's return type from
blockifier::execution::contract_class::ClassInfo
tostarknet_api::contract_class::ClassInfo
.In the following PRs,
MempoolInput
will (indirectly) usestarknet_api::..::ClassInfo
.This change is