Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove optional class info #518

Conversation

ArniStarkware
Copy link
Contributor

@ArniStarkware ArniStarkware commented Aug 19, 2024

This change is Reviewable

Copy link
Contributor Author

ArniStarkware commented Aug 19, 2024

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @ArniStarkware and the rest of your teammates on Graphite Graphite

@ArniStarkware ArniStarkware force-pushed the arni/executable_tx_in_gateway/create_executable_tx branch from 528f847 to 1bd225e Compare August 19, 2024 13:28
@ArniStarkware ArniStarkware force-pushed the arni/executable_tx_in_gateway/remove_optional_class_info branch from fe7f892 to 74144ec Compare August 19, 2024 13:28
@ArniStarkware
Copy link
Contributor Author

crates/gateway/src/stateful_transaction_validator.rs line 78 at r1 (raw file):

            gateway_compiler,
            &self.config.chain_info.chain_id,
        )?;

In #519, we fix the signature of this function.

Code quote:

    pub fn run_validate<V: StatefulTransactionValidatorTrait>(
        &self,
        external_tx: &RpcTransaction,
        gateway_compiler: &GatewayCompiler,
        mut validator: V,
    ) -> StatefulTransactionValidatorResult<ValidateInfo> {
        let account_tx = external_tx_to_account_tx(
            external_tx,
            gateway_compiler,
            &self.config.chain_info.chain_id,
        )?;

@ArniStarkware
Copy link
Contributor Author

This PR is irrelevant. It was squashed into #519.

@ArniStarkware ArniStarkware deleted the arni/executable_tx_in_gateway/remove_optional_class_info branch August 19, 2024 14:14
@ArniStarkware ArniStarkware marked this pull request as ready for review August 19, 2024 14:44
@github-actions github-actions bot locked and limited conversation to collaborators Aug 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant