refactor: change try from casm contract class to be by ref to avoid clones

[ArniStarkware]

This change is 

[ArniStarkware]

• refactor: change try from casm contract class to be by ref to avoid clones #604 👈
• refactor: refactor the stateful tx validator to get executable tx as input #519 : 3 other dependent PRs (#520 , #521 , #789 )
• chore: create executable tx creator for testing #672
• chore: move chain_id create for testing to snapi test utils #666 : 2 other dependent PRs (#694 , #701 )
• chore: move transaction creator test util to starknet api #661
• chore: split the inner tx creator in blockifier test utils #660
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @ArniStarkware and the rest of your teammates on Graphite

[codecov]

Codecov Report

Attention: Patch coverage is 50.00000% with 15 lines in your changes missing coverage. Please review.

Project coverage is 74.23%. Comparing base (f68bd90) to head (ced42c2).
Report is 3 commits behind head on main.

Files with missing lines	Patch %	Lines
crates/blockifier/src/execution/contract_class.rs	70.58%	4 Missing and 1 partial ⚠️
crates/blockifier/src/transaction/transactions.rs	0.00%	3 Missing ⚠️
crates/papyrus_execution/src/lib.rs	0.00%	1 Missing and 1 partial ⚠️
crates/gateway/src/rpc_state_reader.rs	0.00%	0 Missing and 1 partial ⚠️
...ates/gateway/src/stateful_transaction_validator.rs	0.00%	0 Missing and 1 partial ⚠️
...tive_blockifier/src/state_readers/papyrus_state.rs	0.00%	0 Missing and 1 partial ⚠️
crates/papyrus_execution/src/execution_utils.rs	0.00%	0 Missing and 1 partial ⚠️
crates/papyrus_execution/src/state_reader.rs	0.00%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #604      +/-   ##
==========================================
+ Coverage   74.18%   74.23%   +0.05%     
==========================================
  Files         359      359              
  Lines       36240    36234       -6     
  Branches    36240    36234       -6     
==========================================
+ Hits        26884    26900      +16     
+ Misses       7220     7203      -17     
+ Partials     2136     2131       -5     

Flag	Coverage Δ
	74.23% <50.00%> (+0.05%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[ArniStarkware]

crates/gateway/src/stateful_transaction_validator.rs line 83 at r2 (raw file):

            // TODO(Arni): create a try_from for &ExecutableTransaction.
            executable_tx.clone(),
        )

This is the goal of this PR.

Code quote:

            // TODO(Arni): create a try_from for &ExecutableTransaction.
            executable_tx.clone(),
        )

[ArniStarkware]

crates/gateway/src/stateful_transaction_validator.rs line 83 at r2 (raw file):

Previously, ArniStarkware (Arnon Hod) wrote…

This is the goal of this PR.

For declare transaction, this clone might be pretty expensive (The clone might hurt for other transaction types - but it is justifiable in those cases).

[ArniStarkware]

Already merged.