refactor: remove most fields from statful validator output

[ArniStarkware]

The struct ValidateInfo holds all the information relevant to the rest of the transaction's lifecycle from the run of the validate. Most of its members are no longer needed as they can be obtained from the ExecutableTransaction.

This change is 

[ArniStarkware]

• refactor: add account nonce as input of run_validate and remove validation output #822
• refactor: remove most fields from statful validator output #521 👈
• refactor: refactor the stateful tx validator to get executable tx as input #519 : 3 other dependent PRs (#520 , #604 , #789 )
• chore: create executable tx creator for testing #672
• chore: move chain_id create for testing to snapi test utils #666 : 2 other dependent PRs (#694 , #701 )
• chore: move transaction creator test util to starknet api #661
• chore: split the inner tx creator in blockifier test utils #660
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @ArniStarkware and the rest of your teammates on Graphite

[ArniStarkware]

Reviewable status: 0 of 5 files reviewed, all discussions resolved (waiting on @ayeletstarkware, @dafnamatsry, @MohammadNassar1, @Yael-Starkware, and @yair-starkware)

---

crates/gateway/src/gateway.rs line 139 at r1 (raw file):

    let validator = stateful_tx_validator.instantiate_validator(state_reader_factory)?;
    // TODO(Yael 31/7/24): refactor after IntrnalTransaction is ready, delete validate_info and
    // compute all the info outside of run_validate.

This TODO is still relevant.

Code quote:

    // TODO(Yael 31/7/24): refactor after IntrnalTransaction is ready, delete validate_info and
    // compute all the info outside of run_validate.

---

crates/gateway/src/gateway.rs line 147 at r1 (raw file):

        account: Account {
            sender_address: executable_tx.contract_address(),
            state: AccountState { nonce: validate_info.account_nonce },

This member is different from executable_tx.nonce().
One is the nonce of the transaction, while the other is the account's nonce.

Code quote:

 validate_info.account_nonce

[github-actions]

Benchmark movements:
full_committer_flow performance improved 😺
full_committer_flow time: [48.285 ms 48.354 ms 48.429 ms]
change: [-1.4617% -1.2770% -1.0962%] (p = 0.00 < 0.05)
Performance has improved.
Found 5 outliers among 100 measurements (5.00%)
3 (3.00%) high mild
2 (2.00%) high severe

[dafnamatsry]

Reviewed 4 of 4 files at r10, all commit messages.
Reviewable status: 4 of 5 files reviewed, 2 unresolved discussions (waiting on @ayeletstarkware, @MohammadNassar1, @Yael-Starkware, and @yair-starkware)

[github-actions]

Benchmark movements:
tree_computation_flow performance improved 😺
tree_computation_flow time: [66.285 ms 66.414 ms 66.575 ms]
change: [-11.254% -6.2497% -1.9975%] (p = 0.00 < 0.05)
Performance has improved.
Found 6 outliers among 100 measurements (6.00%)
4 (4.00%) high mild
2 (2.00%) high severe

[dafnamatsry]

Reviewed 2 of 2 files at r11, all commit messages.
Reviewable status: 4 of 5 files reviewed, 2 unresolved discussions (waiting on @ayeletstarkware, @MohammadNassar1, @Yael-Starkware, and @yair-starkware)

[yair-starkware]

Reviewed 2 of 4 files at r10, 2 of 2 files at r11.
Reviewable status: 4 of 5 files reviewed, all discussions resolved (waiting on @ayeletstarkware, @dafnamatsry, @MohammadNassar1, and @Yael-Starkware)

[ArniStarkware]

Reviewed 1 of 3 files at r8.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @ayeletstarkware, @dafnamatsry, @MohammadNassar1, and @Yael-Starkware)

[ArniStarkware]

Merge activity

• Sep 22, 3:05 AM EDT: @ArniStarkware started a stack merge that includes this pull request via Graphite.
• Sep 22, 3:05 AM EDT: @ArniStarkware merged this pull request with Graphite.