chore(blockifier): move block info to starknet api #2246

ArniStarkware · 2024-11-24T12:09:44Z

No description provided.

reviewable-StarkWare · 2024-11-24T12:09:52Z

This change is

ArniStarkware · 2024-11-24T12:09:53Z

chore(blockifier): move block info to starknet api #2246 : 2 dependent PRs (#2230 , #2237 ) 👈 (View in Graphite)
chore(blockifier): move GasPrices to snapi #2245
feat(blockifier): derive serialize for block info #2244
chore(blockifier): rename the getters for the gas prices struct #2269
chore(blockifier): separate create and validate logic on gas prices #2243
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

github-actions · 2024-11-24T12:16:32Z

codecov · 2024-11-24T12:31:53Z

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 54.89%. Comparing base (e3165c4) to head (41313e7).
Report is 621 commits behind head on main.

Files with missing lines	Patch %	Lines
crates/starknet_api/src/block.rs	0.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #2246       +/-   ##
===========================================
+ Coverage   40.10%   54.89%   +14.78%     
===========================================
  Files          26      233      +207     
  Lines        1895    26542    +24647     
  Branches     1895    26542    +24647     
===========================================
+ Hits          760    14569    +13809     
- Misses       1100    10948     +9848     
- Partials       35     1025      +990

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

github-actions · 2024-11-24T12:33:30Z

Benchmark movements:
tree_computation_flow performance improved 😺
tree_computation_flow time: [33.856 ms 33.921 ms 33.994 ms]
change: [-5.2342% -3.5742% -2.1011%] (p = 0.00 < 0.05)
Performance has improved.
Found 7 outliers among 100 measurements (7.00%)
5 (5.00%) high mild
2 (2.00%) high severe

alonh5

Reviewed 18 of 18 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @aner-starkware and @dorimedini-starkware)

alonh5

Reviewed 3 of 3 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @aner-starkware and @dorimedini-starkware)

github-actions · 2024-11-28T08:06:32Z

Benchmark movements:
tree_computation_flow performance regressed!
tree_computation_flow time: [34.216 ms 34.688 ms 35.256 ms]
change: [+1.2347% +2.4726% +4.1451%] (p = 0.00 < 0.05)
Performance has regressed.
Found 11 outliers among 100 measurements (11.00%)
3 (3.00%) high mild
8 (8.00%) high severe

alonh5

Reviewed 7 of 7 files at r4, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @aner-starkware and @dorimedini-starkware)

ArniStarkware

Reviewed 1 of 1 files at r5, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @aner-starkware and @dorimedini-starkware)

ArniStarkware · 2024-11-28T10:43:40Z

Merge activity

Nov 28, 5:43 AM EST: A user merged this pull request with Graphite.

This was referenced Nov 24, 2024

chore(blockifier): separate create and validate logic on gas prices #2243

Merged

feat(blockifier): derive serialize for block info #2244

Merged

chore(blockifier): move GasPrices to snapi #2245

Merged

ArniStarkware requested review from alonh5, aner-starkware and dorimedini-starkware November 24, 2024 12:10

ArniStarkware marked this pull request as ready for review November 24, 2024 12:10

ArniStarkware force-pushed the arni/gas_prices/move_to_snapi branch from bfa1ba1 to 6a958f8 Compare November 24, 2024 12:21

ArniStarkware force-pushed the arni/block_info/move_to_snapi branch from 60224f3 to 17f79ac Compare November 24, 2024 12:21

alonh5 approved these changes Nov 24, 2024

View reviewed changes

ArniStarkware force-pushed the arni/gas_prices/move_to_snapi branch from 6a958f8 to f5c93b6 Compare November 24, 2024 14:49

ArniStarkware force-pushed the arni/block_info/move_to_snapi branch from 17f79ac to 77a2f11 Compare November 24, 2024 14:49

alonh5 approved these changes Nov 24, 2024

View reviewed changes

ArniStarkware mentioned this pull request Nov 25, 2024

test(starknet_gateway): handle todo in test_get_block_info #2267

Merged

ArniStarkware force-pushed the arni/gas_prices/move_to_snapi branch from f5c93b6 to f63bc29 Compare November 25, 2024 11:43

ArniStarkware mentioned this pull request Nov 25, 2024

chore(blockifier): rename the getters for the gas prices struct #2269

Merged

ArniStarkware force-pushed the arni/block_info/move_to_snapi branch from 77a2f11 to cdf55d2 Compare November 25, 2024 11:43

ArniStarkware force-pushed the arni/gas_prices/move_to_snapi branch from f63bc29 to d0e9ff5 Compare November 25, 2024 11:49

ArniStarkware force-pushed the arni/block_info/move_to_snapi branch from cdf55d2 to c13e58b Compare November 25, 2024 11:50

ArniStarkware force-pushed the arni/gas_prices/move_to_snapi branch from d0e9ff5 to 2a0a57d Compare November 25, 2024 14:44

ArniStarkware force-pushed the arni/block_info/move_to_snapi branch from c13e58b to a2658a6 Compare November 25, 2024 14:44

ArniStarkware force-pushed the arni/gas_prices/move_to_snapi branch from 0b66a48 to 33cef26 Compare November 28, 2024 07:06

ArniStarkware force-pushed the arni/block_info/move_to_snapi branch 2 times, most recently from 1153ca9 to 697d4e0 Compare November 28, 2024 07:56

ArniStarkware requested a review from alonh5 November 28, 2024 08:10

alonh5 approved these changes Nov 28, 2024

View reviewed changes

ArniStarkware force-pushed the arni/gas_prices/move_to_snapi branch from 33cef26 to fdf402c Compare November 28, 2024 09:17

ArniStarkware force-pushed the arni/block_info/move_to_snapi branch from 697d4e0 to 2c6304f Compare November 28, 2024 09:17

ArniStarkware force-pushed the arni/gas_prices/move_to_snapi branch from fdf402c to 3d7b232 Compare November 28, 2024 09:40

ArniStarkware force-pushed the arni/block_info/move_to_snapi branch from 2c6304f to ce229f2 Compare November 28, 2024 09:41

ArniStarkware force-pushed the arni/gas_prices/move_to_snapi branch 2 times, most recently from 7669ae6 to 4444d1b Compare November 28, 2024 09:57

ArniStarkware force-pushed the arni/block_info/move_to_snapi branch from ce229f2 to a60e8f1 Compare November 28, 2024 09:57

ArniStarkware changed the base branch from arni/gas_prices/move_to_snapi to graphite-base/2246 November 28, 2024 10:18

ArniStarkware force-pushed the graphite-base/2246 branch from 4444d1b to d7198bd Compare November 28, 2024 10:18

ArniStarkware force-pushed the arni/block_info/move_to_snapi branch from a60e8f1 to f991001 Compare November 28, 2024 10:18

ArniStarkware changed the base branch from graphite-base/2246 to main November 28, 2024 10:18

chore(blockifier): move block info to starknet api

41313e7

ArniStarkware force-pushed the arni/block_info/move_to_snapi branch from f991001 to 41313e7 Compare November 28, 2024 10:18

ArniStarkware commented Nov 28, 2024

View reviewed changes

ArniStarkware merged commit 50403e4 into main Nov 28, 2024
23 checks passed

ArniStarkware deleted the arni/block_info/move_to_snapi branch November 28, 2024 13:46

github-actions bot locked and limited conversation to collaborators Dec 1, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(blockifier): move block info to starknet api #2246

chore(blockifier): move block info to starknet api #2246

ArniStarkware commented Nov 24, 2024

reviewable-StarkWare commented Nov 24, 2024

ArniStarkware commented Nov 24, 2024 •

edited

Loading

github-actions bot commented Nov 24, 2024 •

edited

Loading

codecov bot commented Nov 24, 2024 •

edited

Loading

github-actions bot commented Nov 24, 2024

alonh5 left a comment

alonh5 left a comment

github-actions bot commented Nov 28, 2024

alonh5 left a comment

ArniStarkware left a comment

ArniStarkware commented Nov 28, 2024

chore(blockifier): move block info to starknet api #2246

chore(blockifier): move block info to starknet api #2246

Conversation

ArniStarkware commented Nov 24, 2024

reviewable-StarkWare commented Nov 24, 2024

ArniStarkware commented Nov 24, 2024 • edited Loading

github-actions bot commented Nov 24, 2024 • edited Loading

codecov bot commented Nov 24, 2024 • edited Loading

Codecov Report

github-actions bot commented Nov 24, 2024

alonh5 left a comment

Choose a reason for hiding this comment

alonh5 left a comment

Choose a reason for hiding this comment

github-actions bot commented Nov 28, 2024

alonh5 left a comment

Choose a reason for hiding this comment

ArniStarkware left a comment

Choose a reason for hiding this comment

ArniStarkware commented Nov 28, 2024

Merge activity

ArniStarkware commented Nov 24, 2024 •

edited

Loading

github-actions bot commented Nov 24, 2024 •

edited

Loading

codecov bot commented Nov 24, 2024 •

edited

Loading