-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(starknet_batcher): set use_kzg_da flag in build block input #2345
chore(starknet_batcher): set use_kzg_da flag in build block input #2345
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2345 +/- ##
===========================================
- Coverage 40.10% 27.34% -12.77%
===========================================
Files 26 119 +93
Lines 1895 14036 +12141
Branches 1895 14036 +12141
===========================================
+ Hits 760 3838 +3078
- Misses 1100 9863 +8763
- Partials 35 335 +300 ☔ View full report in Codecov by Sentry. |
a21cac0
to
3bb7ed9
Compare
0b1faae
to
ef924ab
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @ArniStarkware)
3bb7ed9
to
c65933e
Compare
f3ada2d
to
f84a046
Compare
c65933e
to
5e58a58
Compare
f84a046
to
4299eb1
Compare
5e58a58
to
83b3f3e
Compare
4299eb1
to
afd4c28
Compare
83b3f3e
to
3d7428d
Compare
afd4c28
to
17c0fe1
Compare
3d7428d
to
5e5126a
Compare
17c0fe1
to
0b3f15b
Compare
2a4a5b5
to
6cfb9f4
Compare
0b3f15b
to
4d6fbbd
Compare
6cfb9f4
to
7426fef
Compare
4d6fbbd
to
38e59dc
Compare
7426fef
to
c2e4423
Compare
38e59dc
to
fd84f65
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r3, 1 of 1 files at r4, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ArniStarkware)
crates/sequencing/papyrus_consensus_orchestrator/src/sequencer_consensus_context.rs
line 175 at r4 (raw file):
now.timestamp().try_into().expect("Failed to convert timestamp"), ), use_kzg_da: true,
Will this become variable in the future? If so where does the info come from?
Code quote:
use_kzg_da: true,
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r3, 1 of 1 files at r4, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @matan-starkware)
crates/sequencing/papyrus_consensus_orchestrator/src/sequencer_consensus_context.rs
line 175 at r4 (raw file):
Previously, matan-starkware wrote…
Will this become variable in the future? If so where does the info come from?
This should always be true unless the blob data price will be higher than regular data storage, which could happen. Hard coding true
for now is fine.
fd84f65
to
ef7066c
Compare
No description provided.