-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(batcher): remove block metadata member from block builder factory #2230
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## arni/block_info/move_to_snapi #2230 +/- ##
=================================================================
- Coverage 55.04% 5.18% -49.86%
=================================================================
Files 232 146 -86
Lines 26264 16981 -9283
Branches 26264 16981 -9283
=================================================================
- Hits 14456 880 -13576
- Misses 10789 16027 +5238
+ Partials 1019 74 -945 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
e221112
to
54dff5c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @alonh5 and @dafnamatsry)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @dafnamatsry)
54dff5c
to
a33b3cc
Compare
Artifacts upload workflows: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 2 of 3 files reviewed, 1 unresolved discussion (waiting on @ArniStarkware, @dafnamatsry, and @Yael-Starkware)
a discussion (no related file):
Is this PR still relevant? Instead of removing this here and then adding the block info (which contains these fields), you can just replace it in the same PR.
Previously, alonh5 (Alon Haramati) wrote…
This Pr is indeed no longer relevant. |
This PR is no longer relevant. |
Refactor towards getting block info from consensus.