Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(starknet_consensus_manager): set proposer address in propose block input #2346

Conversation

ArniStarkware
Copy link
Contributor

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link

codecov bot commented Nov 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 18.08%. Comparing base (e3165c4) to head (c2fba98).
Report is 681 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2346       +/-   ##
===========================================
- Coverage   40.10%   18.08%   -22.03%     
===========================================
  Files          26      119       +93     
  Lines        1895    14043    +12148     
  Branches     1895    14043    +12148     
===========================================
+ Hits          760     2539     +1779     
- Misses       1100    11234    +10134     
- Partials       35      270      +235     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ArniStarkware
Copy link
Contributor Author

crates/sequencing/papyrus_consensus_orchestrator/src/sequencer_consensus_context.rs line 293 at r1 (raw file):

            None => true,
        };
        if condition {

remove, this is not a part of this PR.

Code quote:

    ) {
        let condition = match self.current_height {
            Some(h) => h < height,
            None => true,
        };
        if condition {

@ArniStarkware ArniStarkware changed the title chore(consensus): set proposer address in propose block input chore(starknet_consensus_manager): set proposer address in propose block input Dec 1, 2024
@ArniStarkware ArniStarkware force-pushed the arni/batcher/block_builder_factory/set_use_kzg_da_in_build_block_input branch from ef924ab to f3ada2d Compare December 1, 2024 12:53
@ArniStarkware ArniStarkware force-pushed the arni/batcher/block_builder_factory/set_propser_address_in_build_block_input branch from 8049c64 to 350ca29 Compare December 1, 2024 13:00
@ArniStarkware ArniStarkware force-pushed the arni/batcher/block_builder_factory/set_use_kzg_da_in_build_block_input branch from f3ada2d to f84a046 Compare December 1, 2024 13:52
@ArniStarkware ArniStarkware force-pushed the arni/batcher/block_builder_factory/set_propser_address_in_build_block_input branch from 350ca29 to d3ead1e Compare December 1, 2024 13:52
@ArniStarkware ArniStarkware force-pushed the arni/batcher/block_builder_factory/set_use_kzg_da_in_build_block_input branch 4 times, most recently from 17c0fe1 to 0b3f15b Compare December 2, 2024 14:33
@ArniStarkware ArniStarkware force-pushed the arni/batcher/block_builder_factory/set_propser_address_in_build_block_input branch from d3ead1e to 0dc1db4 Compare December 2, 2024 14:33
@ArniStarkware ArniStarkware force-pushed the arni/batcher/block_builder_factory/set_use_kzg_da_in_build_block_input branch from 0b3f15b to 4d6fbbd Compare December 2, 2024 15:05
@ArniStarkware ArniStarkware force-pushed the arni/batcher/block_builder_factory/set_propser_address_in_build_block_input branch from 0dc1db4 to 9c9aa6c Compare December 2, 2024 15:05
@ArniStarkware ArniStarkware force-pushed the arni/batcher/block_builder_factory/set_use_kzg_da_in_build_block_input branch from 4d6fbbd to 38e59dc Compare December 2, 2024 15:27
@ArniStarkware ArniStarkware force-pushed the arni/batcher/block_builder_factory/set_propser_address_in_build_block_input branch from 9c9aa6c to e104f26 Compare December 2, 2024 15:27
@ArniStarkware ArniStarkware force-pushed the arni/batcher/block_builder_factory/set_use_kzg_da_in_build_block_input branch from 38e59dc to fd84f65 Compare December 3, 2024 10:59
@ArniStarkware ArniStarkware force-pushed the arni/batcher/block_builder_factory/set_propser_address_in_build_block_input branch from e104f26 to b6a3940 Compare December 3, 2024 10:59
@ArniStarkware ArniStarkware changed the base branch from arni/batcher/block_builder_factory/set_use_kzg_da_in_build_block_input to graphite-base/2346 December 3, 2024 12:32
Copy link
Contributor

@matan-starkware matan-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 9 files reviewed, 1 unresolved discussion (waiting on @alonh5, @ArniStarkware, and @dan-starkware)


crates/sequencing/papyrus_consensus/src/types.rs line 122 at r3 (raw file):

        round: Round,
        proposer: ValidatorId,
    );

Why would I pass this here? The node's ID is set on startup, not every round.

Code quote:

    async fn set_height_and_round(
        &mut self,
        height: BlockNumber,
        round: Round,
        proposer: ValidatorId,
    );

Copy link
Contributor

@matan-starkware matan-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 9 files reviewed, 1 unresolved discussion (waiting on @alonh5, @ArniStarkware, and @dan-starkware)


crates/sequencing/papyrus_consensus/src/types.rs line 122 at r3 (raw file):

Previously, matan-starkware wrote…

Why would I pass this here? The node's ID is set on startup, not every round.

I think what you want is to add the proposer to self.queued_proposals

@ArniStarkware ArniStarkware force-pushed the arni/batcher/block_builder_factory/set_propser_address_in_build_block_input branch from b6a3940 to b469204 Compare December 3, 2024 12:52
@ArniStarkware ArniStarkware changed the base branch from graphite-base/2346 to main December 3, 2024 12:53
@ArniStarkware ArniStarkware force-pushed the arni/batcher/block_builder_factory/set_propser_address_in_build_block_input branch from b469204 to 38d7da8 Compare December 3, 2024 12:53
@ArniStarkware ArniStarkware force-pushed the arni/batcher/block_builder_factory/set_propser_address_in_build_block_input branch from 38d7da8 to c2fba98 Compare December 3, 2024 14:15
Copy link
Contributor Author

@ArniStarkware ArniStarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 9 files reviewed, 1 unresolved discussion (waiting on @alonh5, @dan-starkware, and @matan-starkware)


crates/sequencing/papyrus_consensus/src/types.rs line 122 at r3 (raw file):

Previously, matan-starkware wrote…

I think what you want is to add the proposer to self.queued_proposals

Done.

Copy link
Contributor

@matan-starkware matan-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 9 files at r3, 8 of 8 files at r4, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @alonh5 and @dan-starkware)

@ArniStarkware ArniStarkware merged commit 4fab329 into main Dec 3, 2024
16 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants