-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(starknet_consensus_manager): set proposer address in propose block input #2346
chore(starknet_consensus_manager): set proposer address in propose block input #2346
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2346 +/- ##
===========================================
- Coverage 40.10% 18.08% -22.03%
===========================================
Files 26 119 +93
Lines 1895 14043 +12148
Branches 1895 14043 +12148
===========================================
+ Hits 760 2539 +1779
- Misses 1100 11234 +10134
- Partials 35 270 +235 ☔ View full report in Codecov by Sentry. |
0b1faae
to
ef924ab
Compare
21c7cc4
to
8049c64
Compare
remove, this is not a part of this PR. Code quote: ) {
let condition = match self.current_height {
Some(h) => h < height,
None => true,
};
if condition { |
ef924ab
to
f3ada2d
Compare
8049c64
to
350ca29
Compare
f3ada2d
to
f84a046
Compare
350ca29
to
d3ead1e
Compare
17c0fe1
to
0b3f15b
Compare
d3ead1e
to
0dc1db4
Compare
0b3f15b
to
4d6fbbd
Compare
0dc1db4
to
9c9aa6c
Compare
4d6fbbd
to
38e59dc
Compare
9c9aa6c
to
e104f26
Compare
38e59dc
to
fd84f65
Compare
e104f26
to
b6a3940
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 9 files reviewed, 1 unresolved discussion (waiting on @alonh5, @ArniStarkware, and @dan-starkware)
crates/sequencing/papyrus_consensus/src/types.rs
line 122 at r3 (raw file):
round: Round, proposer: ValidatorId, );
Why would I pass this here? The node's ID is set on startup, not every round.
Code quote:
async fn set_height_and_round(
&mut self,
height: BlockNumber,
round: Round,
proposer: ValidatorId,
);
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 9 files reviewed, 1 unresolved discussion (waiting on @alonh5, @ArniStarkware, and @dan-starkware)
crates/sequencing/papyrus_consensus/src/types.rs
line 122 at r3 (raw file):
Previously, matan-starkware wrote…
Why would I pass this here? The node's ID is set on startup, not every round.
I think what you want is to add the proposer to self.queued_proposals
fd84f65
to
b7934f4
Compare
b6a3940
to
b469204
Compare
b469204
to
38d7da8
Compare
38d7da8
to
c2fba98
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 9 files reviewed, 1 unresolved discussion (waiting on @alonh5, @dan-starkware, and @matan-starkware)
crates/sequencing/papyrus_consensus/src/types.rs
line 122 at r3 (raw file):
Previously, matan-starkware wrote…
I think what you want is to add the proposer to
self.queued_proposals
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 9 files at r3, 8 of 8 files at r4, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @alonh5 and @dan-starkware)
No description provided.