feat(blockifier): add n_allocated_keys #2149

yoavGrs · 2024-11-18T16:11:55Z

No description provided.

reviewable-StarkWare · 2024-11-18T16:12:03Z

This change is

github-actions · 2024-11-18T16:15:01Z

Artifacts upload triggered. View details here

codecov · 2024-11-18T16:20:09Z

Codecov Report

Attention: Patch coverage is 73.91304% with 6 lines in your changes missing coverage. Please review.

Project coverage is 68.67%. Comparing base (e3165c4) to head (d8ad5ee).
Report is 586 commits behind head on main.

Files with missing lines	Patch %	Lines
crates/blockifier/src/state/cached_state.rs	73.91%	6 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #2149       +/-   ##
===========================================
+ Coverage   40.10%   68.67%   +28.56%     
===========================================
  Files          26      108       +82     
  Lines        1895    13924    +12029     
  Branches     1895    13924    +12029     
===========================================
+ Hits          760     9562     +8802     
- Misses       1100     3951     +2851     
- Partials       35      411      +376

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

dorimedini-starkware

Reviewed all commit messages.
Reviewable status: 0 of 13 files reviewed, 1 unresolved discussion (waiting on @nimrod-starkware and @yoavGrs)

a discussion (no related file):
please split this PR
there are functions being moved to different types here, they can be separated (if you can think of other things that can be split away please do)

github-actions · 2024-11-19T11:19:02Z

Artifacts upload triggered. View details here

github-actions · 2024-11-19T12:30:39Z

Artifacts upload triggered. View details here

github-actions · 2024-11-19T12:56:42Z

Artifacts upload triggered. View details here

dorimedini-starkware

Reviewed 13 of 13 files at r7, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @nimrod-starkware and @yoavGrs)

crates/blockifier/src/state/cached_state.rs line 687 at r7 (raw file):

impl AllocatedKeys {
    pub fn extend(&mut self, state_change: &StateChanges) {

you are not going to implement this with extend later

Suggestion:

update

crates/blockifier/src/state/cached_state.rs line 692 at r7 (raw file):

    }

    pub fn count(&self) -> usize {

seems natural, non-blocking

Suggestion:

len

yoavGrs · 2024-11-19T15:43:37Z

This stack of pull requests is managed by Graphite. Learn more about stacking.

yoavGrs

Reviewable status: 10 of 13 files reviewed, 2 unresolved discussions (waiting on @dorimedini-starkware and @nimrod-starkware)

a discussion (no related file):

Previously, dorimedini-starkware wrote…

please split this PR
there are functions being moved to different types here, they can be separated (if you can think of other things that can be split away please do)

Done.

crates/blockifier/src/state/cached_state.rs line 687 at r7 (raw file):

Previously, dorimedini-starkware wrote…

you are not going to implement this with extend later

Done.

crates/blockifier/src/state/cached_state.rs line 692 at r7 (raw file):

Previously, dorimedini-starkware wrote…

seems natural, non-blocking

Rust asks me to implement is_empty as well.

github-actions · 2024-11-19T15:45:04Z

Artifacts upload triggered. View details here

dorimedini-starkware

Reviewed 3 of 3 files at r8, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @nimrod-starkware)

crates/blockifier/src/state/cached_state.rs line 692 at r7 (raw file):

Previously, yoavGrs wrote…

Rust asks me to implement is_empty as well.

lol ok

github-actions · 2024-11-20T06:36:27Z

Artifacts upload triggered. View details here

dorimedini-starkware

Reviewed 3 of 3 files at r9, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @nimrod-starkware)

github-actions · 2024-11-25T14:00:18Z

Artifacts upload workflows:

dorimedini-starkware

Reviewed 3 of 3 files at r10, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @nimrod-starkware)

yoavGrs · 2024-11-26T10:53:12Z

Merge activity

Nov 26, 5:53 AM EST: A user started a stack merge that includes this pull request via Graphite.
Nov 26, 5:55 AM EST: Graphite rebased this pull request as part of a merge.
Nov 26, 6:13 AM EST: A user merged this pull request with Graphite.

dorimedini-starkware

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @nimrod-starkware)

yoavGrs requested review from dorimedini-starkware and nimrod-starkware November 18, 2024 16:11

yoavGrs self-assigned this Nov 18, 2024

dorimedini-starkware requested changes Nov 18, 2024

View reviewed changes

yoavGrs force-pushed the yoav/compression/allocated_keys_structure branch from 34effde to c25c984 Compare November 19, 2024 11:17

yoavGrs changed the base branch from main to yoav/compression/state_changes_count_for_fee November 19, 2024 12:28

yoavGrs force-pushed the yoav/compression/allocated_keys_structure branch from c25c984 to 63e3201 Compare November 19, 2024 12:56

dorimedini-starkware requested changes Nov 19, 2024

View reviewed changes

yoavGrs force-pushed the yoav/compression/state_changes_count_for_fee branch from 46a6da2 to 868b6b6 Compare November 19, 2024 15:43

yoavGrs force-pushed the yoav/compression/allocated_keys_structure branch from 63e3201 to 2d9b007 Compare November 19, 2024 15:43

yoavGrs commented Nov 19, 2024

View reviewed changes

dorimedini-starkware approved these changes Nov 19, 2024

View reviewed changes

yoavGrs force-pushed the yoav/compression/state_changes_count_for_fee branch from 868b6b6 to d7d90ca Compare November 20, 2024 06:34

yoavGrs force-pushed the yoav/compression/allocated_keys_structure branch from 2d9b007 to 2e91cee Compare November 20, 2024 06:34

dorimedini-starkware approved these changes Nov 20, 2024

View reviewed changes

yoavGrs force-pushed the yoav/compression/state_changes_count_for_fee branch from d7d90ca to 3cf36e7 Compare November 25, 2024 13:58

yoavGrs force-pushed the yoav/compression/allocated_keys_structure branch from 2e91cee to 13f1440 Compare November 25, 2024 13:58

yoavGrs force-pushed the yoav/compression/state_changes_count_for_fee branch from 3cf36e7 to bb121ba Compare November 25, 2024 15:07

yoavGrs force-pushed the yoav/compression/allocated_keys_structure branch from 13f1440 to 13ad371 Compare November 25, 2024 15:07

yoavGrs mentioned this pull request Nov 25, 2024

feat(blockifier): add allocation cost versioned constant #2200

Merged

yoavGrs force-pushed the yoav/compression/state_changes_count_for_fee branch from bb121ba to d3b22a0 Compare November 25, 2024 16:02

yoavGrs force-pushed the yoav/compression/allocated_keys_structure branch from 13ad371 to 9a5a07d Compare November 25, 2024 16:02

yoavGrs changed the base branch from yoav/compression/state_changes_count_for_fee to yoav/compression/allocation_cost_constant November 26, 2024 09:09

yoavGrs force-pushed the yoav/compression/allocated_keys_structure branch from 9a5a07d to f3f9f90 Compare November 26, 2024 09:09

dorimedini-starkware approved these changes Nov 26, 2024

View reviewed changes

yoavGrs changed the base branch from yoav/compression/allocation_cost_constant to graphite-base/2149 November 26, 2024 10:53

yoavGrs changed the base branch from graphite-base/2149 to main November 26, 2024 10:53

dorimedini-starkware approved these changes Nov 26, 2024

View reviewed changes

feat(blockifier): add n_allocated_keys

d8ad5ee

yoavGrs force-pushed the yoav/compression/allocated_keys_structure branch from f3f9f90 to d8ad5ee Compare November 26, 2024 10:54

yoavGrs merged commit f1fb7c8 into main Nov 26, 2024
13 checks passed

This was referenced Nov 27, 2024

feat(blockifier): two allocation_cost gas vectors #2293

Merged

feat(starknet_api): checked mul for gas vector #2300

Merged

feat(blockifier): compute allocation cost #2301

Merged

fix(blockifier): merge state diff with squash #2310

Merged

github-actions bot locked and limited conversation to collaborators Nov 29, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(blockifier): add n_allocated_keys #2149

feat(blockifier): add n_allocated_keys #2149

yoavGrs commented Nov 18, 2024

reviewable-StarkWare commented Nov 18, 2024

github-actions bot commented Nov 18, 2024

codecov bot commented Nov 18, 2024 •

edited

Loading

dorimedini-starkware left a comment

github-actions bot commented Nov 19, 2024

github-actions bot commented Nov 19, 2024

github-actions bot commented Nov 19, 2024

dorimedini-starkware left a comment

yoavGrs commented Nov 19, 2024 •

edited

Loading

yoavGrs left a comment

github-actions bot commented Nov 19, 2024

dorimedini-starkware left a comment

github-actions bot commented Nov 20, 2024

dorimedini-starkware left a comment

github-actions bot commented Nov 25, 2024 •

edited

Loading

dorimedini-starkware left a comment

yoavGrs commented Nov 26, 2024 •

edited

Loading

dorimedini-starkware left a comment

feat(blockifier): add n_allocated_keys #2149

feat(blockifier): add n_allocated_keys #2149

Conversation

yoavGrs commented Nov 18, 2024

reviewable-StarkWare commented Nov 18, 2024

github-actions bot commented Nov 18, 2024

codecov bot commented Nov 18, 2024 • edited Loading

Codecov Report

dorimedini-starkware left a comment

Choose a reason for hiding this comment

github-actions bot commented Nov 19, 2024

github-actions bot commented Nov 19, 2024

github-actions bot commented Nov 19, 2024

dorimedini-starkware left a comment

Choose a reason for hiding this comment

yoavGrs commented Nov 19, 2024 • edited Loading

yoavGrs left a comment

Choose a reason for hiding this comment

github-actions bot commented Nov 19, 2024

dorimedini-starkware left a comment

Choose a reason for hiding this comment

github-actions bot commented Nov 20, 2024

dorimedini-starkware left a comment

Choose a reason for hiding this comment

github-actions bot commented Nov 25, 2024 • edited Loading

dorimedini-starkware left a comment

Choose a reason for hiding this comment

yoavGrs commented Nov 26, 2024 • edited Loading

Merge activity

dorimedini-starkware left a comment

Choose a reason for hiding this comment

codecov bot commented Nov 18, 2024 •

edited

Loading

yoavGrs commented Nov 19, 2024 •

edited

Loading

github-actions bot commented Nov 25, 2024 •

edited

Loading

yoavGrs commented Nov 26, 2024 •

edited

Loading