Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(blockifier): diff of StateCache is StateChanges #2174

Merged
merged 1 commit into from
Nov 25, 2024
Merged

refactor(blockifier): diff of StateCache is StateChanges #2174

merged 1 commit into from
Nov 25, 2024

Conversation

yoavGrs
Copy link
Contributor

@yoavGrs yoavGrs commented Nov 19, 2024

No description provided.

@yoavGrs yoavGrs self-assigned this Nov 19, 2024
@reviewable-StarkWare
Copy link

This change is Reviewable

@github-actions GitHub Actions
Copy link

Artifacts upload triggered. View details here

@codecov Codecov
Copy link

codecov bot commented Nov 19, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 53.84615% with 6 lines in your changes missing coverage. Please review.

Project coverage is 64.45%. Comparing base (e3165c4) to head (eade519).
Report is 574 commits behind head on main.

Files with missing lines Patch % Lines
.../blockifier/src/blockifier/transaction_executor.rs 0.00% 5 Missing ⚠️
crates/papyrus_execution/src/execution_utils.rs 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##             main    #2174       +/-   ##
===========================================
+ Coverage   40.10%   64.45%   +24.34%     
===========================================
  Files          26      141      +115     
  Lines        1895    17868    +15973     
  Branches     1895    17868    +15973     
===========================================
+ Hits          760    11516    +10756     
- Misses       1100     5558     +4458     
- Partials       35      794      +759

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚨 Try these New Features:

dorimedini-starkware
dorimedini-starkware approved these changes Nov 19, 2024
View reviewed changes
Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @yoavGrs)

a discussion (no related file):
please edit the commit message and the PR title (probably copied from 2173 by mistake)

@yoavGrs yoavGrs changed the title refactor(blockifier): move functions to state maps refactor(blockifier): diff of StateCache is StateChanges Nov 19, 2024
@github-actions GitHub Actions
Copy link

Artifacts upload triggered. View details here

@yoavGrs yoavGrs force-pushed the yoav/compression/move_funcs_to_state_maps branch from 08c21c4 to e9f33b7 Compare November 19, 2024 15:43
@yoavGrs yoavGrs force-pushed the yoav/compression/refactor_diff_of_cached_state branch from 539d545 to 4832a87 Compare November 19, 2024 15:43
@yoavGrs Graphite App
Copy link
Contributor Author

yoavGrs commented Nov 19, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

This was referenced Nov 19, 2024
Merged
Merged
Merged
Merged
Merged
yoavGrs
yoavGrs commented Nov 19, 2024
View reviewed changes
Copy link
Contributor Author

@yoavGrs yoavGrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed (commit messages unreviewed), 1 unresolved discussion (waiting on @dorimedini-starkware)

a discussion (no related file):

Previously, dorimedini-starkware wrote…

please edit the commit message and the PR title (probably copied from 2173 by mistake)

Done.

@github-actions GitHub Actions
Copy link

Artifacts upload triggered. View details here

dorimedini-starkware
dorimedini-starkware approved these changes Nov 19, 2024
View reviewed changes
Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @yoavGrs)

@yoavGrs yoavGrs force-pushed the yoav/compression/move_funcs_to_state_maps branch from e9f33b7 to eb83d09 Compare November 20, 2024 06:33
@yoavGrs yoavGrs force-pushed the yoav/compression/refactor_diff_of_cached_state branch from 4832a87 to f799e59 Compare November 20, 2024 06:34
@github-actions GitHub Actions
Copy link

Artifacts upload triggered. View details here

dorimedini-starkware
dorimedini-starkware approved these changes Nov 20, 2024
View reviewed changes
Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 4 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @yoavGrs)

@yoavGrs Graphite App
Copy link
Contributor Author

yoavGrs commented Nov 20, 2024 •
edited
Loading

Merge activity

  • Nov 20, 9:55 AM EST: A user started a stack merge that includes this pull request via Graphite.
  • Nov 20, 9:58 AM EST: Graphite rebased this pull request as part of a merge.
  • Nov 20, 10:01 AM EST: Graphite couldn't merge this PR because it was not satisfying all requirements (Failed CI: 'merge-gatekeeper', 'code_style').

@yoavGrs yoavGrs changed the base branch from yoav/compression/move_funcs_to_state_maps to graphite-base/2174 November 20, 2024 14:56
@yoavGrs yoavGrs changed the base branch from graphite-base/2174 to main November 20, 2024 14:56
@github-actions GitHub Actions
Copy link

Artifacts upload triggered. View details here

@yoavGrs yoavGrs force-pushed the yoav/compression/refactor_diff_of_cached_state branch from f799e59 to 3ae6b44 Compare November 20, 2024 14:57
@github-actions GitHub Actions
Copy link

Artifacts upload triggered. View details here

@github-actions GitHub Actions
Copy link

Artifacts upload triggered. View details here

dorimedini-starkware
dorimedini-starkware approved these changes Nov 20, 2024
View reviewed changes
Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @yoavGrs)

@yoavGrs yoavGrs force-pushed the yoav/compression/refactor_diff_of_cached_state branch from 3ae6b44 to eade519 Compare November 20, 2024 15:51
@github-actions GitHub Actions
Copy link

Artifacts upload triggered. View details here

dorimedini-starkware
dorimedini-starkware approved these changes Nov 20, 2024
View reviewed changes
Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @yoavGrs)

@yoavGrs yoavGrs merged commit aa0115b into main Nov 25, 2024
19 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dorimedini-starkware dorimedini-starkware dorimedini-starkware approved these changes

Assignees

@yoavGrs yoavGrs

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yoavGrs @reviewable-StarkWare @dorimedini-starkware