feat(blockifier): add allocation cost versioned constant #2200
Conversation
|
This change is |
|
Artifacts upload triggered. View details here |
yoavGrs
force-pushed
the
yoav/compression/allocation_cost_constant
branch
from
2e1272f to
8d8699b
Compare
|
Artifacts upload triggered. View details here |
There was a problem hiding this comment.
Reviewed 7 of 7 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @yoavGrs and @Yoni-Starkware)
crates/blockifier/src/versioned_constants.rs line 188 at r1 (raw file):
// Fee related. pub(crate) vm_resource_fee_cost: Arc<VmResourceCosts>, // Cost in units of onchain data segment length
- end in punctuation
- @Yoni-Starkware should these be some other units...? e.g. sierra gas? allocations incur L2 costs, not L1
Code quote:
// Cost in units of onchain data segment length
yoavGrs
force-pushed
the
yoav/compression/allocation_cost_constant
branch
from
8d8699b to
cf88e58
Compare
|
Artifacts upload workflows: |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2200 +/- ##
===========================================
+ Coverage 40.10% 68.65% +28.54%
===========================================
Files 26 108 +82
Lines 1895 13896 +12001
Branches 1895 13896 +12001
===========================================
+ Hits 760 9540 +8780
- Misses 1100 3946 +2846
- Partials 35 410 +375 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Reviewable status: 0 of 8 files reviewed, 2 unresolved discussions (waiting on @dorimedini-starkware and @Yoni-Starkware)
a discussion (no related file):
Python side:
https://reviewable.io/reviews/starkware-industries/starkware/36292
crates/blockifier/src/versioned_constants.rs line 188 at r1 (raw file):
Previously, dorimedini-starkware wrote…
- end in punctuation
- @Yoni-Starkware should these be some other units...? e.g. sierra gas? allocations incur L2 costs, not L1
Done.
There was a problem hiding this comment.
Reviewed 8 of 8 files at r2, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @dorimedini-starkware and @yoavGrs)
There was a problem hiding this comment.
Reviewed all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @yoavGrs)
No description provided.