Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(blockifier): state_maps is field in StateChanges #2172

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

yoavGrs
Copy link
Contributor

@yoavGrs yoavGrs commented Nov 19, 2024

No description provided.

@yoavGrs yoavGrs self-assigned this Nov 19, 2024
@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link

Artifacts upload triggered. View details here

Copy link

codecov bot commented Nov 19, 2024

Codecov Report

Attention: Patch coverage is 92.85714% with 1 line in your changes missing coverage. Please review.

Project coverage is 69.33%. Comparing base (e3165c4) to head (d0a53fe).
Report is 509 commits behind head on main.

Files with missing lines Patch % Lines
crates/blockifier/src/state/cached_state.rs 92.30% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2172       +/-   ##
===========================================
+ Coverage   40.10%   69.33%   +29.22%     
===========================================
  Files          26      108       +82     
  Lines        1895    13964    +12069     
  Branches     1895    13964    +12069     
===========================================
+ Hits          760     9682     +8922     
- Misses       1100     3875     +2775     
- Partials       35      407      +372     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @yoavGrs)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants