chore(mempool_types): unify client implementations

[Itay-Tsabary-Starkware]

Stack:

• chore(sequencer_infra): remove redundant clones #2119
• refactor: rename generic param in client trait impl #2115
• chore(mempool_types): unify client implementations #2090 ⬅
• chore(mempool_p2p_types): unify client implementations #2089
• chore(gateway): unify client implementations #2088
• chore(sequencer_infra): restructure code to avoid clone trait bound #2087
• chore(batcher): unify client implementations #2086
• chore(sequencer_infra): add component client trait for remote client #2085

⚠️ Part of a stack created by spr. Do not merge manually using the UI - doing so may have unexpected results.

[reviewable-StarkWare]

This change is 

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 3.06%. Comparing base (2018498) to head (c3a2688).

Additional details and impacted files

@@                 Coverage Diff                  @@
##           spr/main/c52611c9   #2090      +/-   ##
====================================================
- Coverage               4.10%   3.06%   -1.04%     
====================================================
  Files                    207     108      -99     
  Lines                  27043   13585   -13458     
  Branches               27043   13585   -13458     
====================================================
- Hits                    1110     417     -693     
+ Misses                 25851   13152   -12699     
+ Partials                  82      16      -66     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[nadin-Starkware]

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @Itay-Tsabary-Starkware)

---

crates/starknet_mempool_types/src/communication.rs line 73 at r1 (raw file):

#[async_trait]
impl<T> MempoolClient for T

Please replace T with a more descriptive name.

Code quote:

T

[Itay-Tsabary-Starkware]

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @nadin-Starkware)

---

crates/starknet_mempool_types/src/communication.rs line 73 at r1 (raw file):

Previously, nadin-Starkware (Nadin Jbara) wrote…

Please replace T with a more descriptive name.

Single pr at the end

[nadin-Starkware]

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @Itay-Tsabary-Starkware)

[Itay-Tsabary-Starkware]

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @Itay-Tsabary-Starkware)

[Itay-Tsabary-Starkware]

✓ Commit merged in pull request #2119