chore(mempool_p2p_types): unify client implementations

[Itay-Tsabary-Starkware]

Stack:

• chore(sequencer_infra): remove redundant clones #2119
• refactor: rename generic param in client trait impl #2115
• chore(mempool_types): unify client implementations #2090
• chore(mempool_p2p_types): unify client implementations #2089 ⬅
• chore(gateway): unify client implementations #2088
• chore(sequencer_infra): restructure code to avoid clone trait bound #2087
• chore(batcher): unify client implementations #2086
• chore(sequencer_infra): add component client trait for remote client #2085

⚠️ Part of a stack created by spr. Do not merge manually using the UI - doing so may have unexpected results.

[reviewable-StarkWare]

This change is 

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 4.10%. Comparing base (c132efb) to head (2018498).

Additional details and impacted files

@@                  Coverage Diff                  @@
##           spr/main/38f81a29   #2089       +/-   ##
=====================================================
- Coverage              16.63%   4.10%   -12.54%     
=====================================================
  Files                    185     207       +22     
  Lines                  22405   27043     +4638     
  Branches               22405   27043     +4638     
=====================================================
- Hits                    3727    1110     -2617     
- Misses                 18445   25851     +7406     
+ Partials                 233      82      -151     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[nadin-Starkware]

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @Itay-Tsabary-Starkware)

---

crates/starknet_mempool_p2p_types/src/communication.rs line 69 at r1 (raw file):

#[async_trait]
impl<T> MempoolP2pPropagatorClient for T

Please replace T with a more descriptive name.

Code quote:

T

[Itay-Tsabary-Starkware]

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @nadin-Starkware)

---

crates/starknet_mempool_p2p_types/src/communication.rs line 69 at r1 (raw file):

Previously, nadin-Starkware (Nadin Jbara) wrote…

Please replace T with a more descriptive name.

Single pr at the end

[nadin-Starkware]

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @Itay-Tsabary-Starkware)

[Itay-Tsabary-Starkware]

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @Itay-Tsabary-Starkware)

[Itay-Tsabary-Starkware]

✓ Commit merged in pull request #2119