-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(gateway): unify client implementations #2088
Conversation
ef1a4f4
to
b9345d7
Compare
15f46aa
to
dc7dfd3
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## spr/main/bdbb68f7 #2088 +/- ##
======================================================
- Coverage 56.22% 16.63% -39.60%
======================================================
Files 8 185 +177
Lines 297 22405 +22108
Branches 297 22405 +22108
======================================================
+ Hits 167 3727 +3560
- Misses 116 18445 +18329
- Partials 14 233 +219 ☔ View full report in Codecov by Sentry. |
61d5549
to
259d982
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @Itay-Tsabary-Starkware)
crates/starknet_gateway_types/src/communication.rs
line 58 at r1 (raw file):
#[async_trait] impl<T> GatewayClient for T
Please replace T with a more descriptive name.
Code quote:
T
cfeaf8d
to
8b4b960
Compare
259d982
to
4e26682
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @nadin-Starkware)
crates/starknet_gateway_types/src/communication.rs
line 58 at r1 (raw file):
Previously, nadin-Starkware (Nadin Jbara) wrote…
Please replace T with a more descriptive name.
Single pr at the end
commit-id:38f81a29
4e26682
to
c132efb
Compare
8b4b960
to
63f6b70
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @Itay-Tsabary-Starkware)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @Itay-Tsabary-Starkware)
✓ Commit merged in pull request #2119 |
Stack: